-
Notifications
You must be signed in to change notification settings - Fork 1.5k
vivid: Add version 0.10.1 #16100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vivid: Add version 0.10.1 #16100
Conversation
WalkthroughAdds a new Scoop manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
All changes look good. Wait for review from human collaborators. vivid
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
bucket/vivid.json (2)
6-15
: Tune notes for Windows and trim deprecated tooling.
- Include a PowerShell example alongside the POSIX export to reduce confusion.
- Consider dropping exa (deprecated upstream) and highlight eza/lsd which honor LS_COLORS on Windows.
"notes": [ - "vivid generates LS_COLORS for colorizing file listings in terminals.", - "Requires GNU coreutils (ls) or compatible tools to display colors:", - " scoop install coreutils", - " scoop install extras/exa", - " scoop install extras/lsd", - "", - "Usage: export LS_COLORS=\"$(vivid generate molokai)\"", - "Available themes: vivid themes" + "vivid generates LS_COLORS for colorizing file listings.", + "Tools that use LS_COLORS on Windows include eza and lsd; GNU coreutils ls also works:", + " scoop install coreutils", + " scoop install eza", + " scoop install extras/lsd", + "", + "POSIX shells: export LS_COLORS=\"$(vivid generate molokai)\"", + "PowerShell: $env:LS_COLORS = (vivid.exe generate molokai)", + "Available themes: vivid themes" ],
16-19
: Adjust suggest bucket qualifiers.eza lives in main; exa is deprecated. Suggest listing eza and lsd; keep coreutils.
"suggest": { "GNU coreutils": "coreutils", - "Modern ls alternatives": ["extras/exa", "extras/lsd", "extras/eza"] + "Modern ls alternatives": ["eza", "extras/lsd"] },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
bucket/vivid.json
(1 hunks)
🔇 Additional comments (3)
bucket/vivid.json (3)
1-47
: Solid, complete manifest overall.URLs, extract_dir, bin, checkver, and autoupdate patterns look consistent with the upstream v0.10.1 release. Nice job supporting both 64-bit and 32-bit MSVC builds. (github.com)
33-45
: Autoupdate and checkver look correct.Patterns match upstream naming; extract_dir templates are aligned with asset folders. No changes needed.
21-30
: Manual verification required
Automated SHA256 checks failed due to SSL certificate errors. Please manually download both Windows MSVC zip assets for v0.10.1 and confirm their SHA256 hashes match those inbucket/vivid.json
before merging.
accept suggestion from coderabbitai - add more window platform related instructions - correct bucket category for every mentioned app - SPDX-style license expressions in favor of scoop convention
@noidilin Thanks! I've added you as a co-author of ScoopInstaller/Main#6718. |
Closing this as ScoopInstaller/Main#6718 has been merged. |
Added a manifest for vivid version 0.10.1.
Close ScoopInstaller/Main#7223
<manifest-name[@version]|chore>: <general summary of the pull request>
Summary
Summary by CodeRabbit
New Features
Documentation