Skip to content

Conversation

@zeldrisho
Copy link
Contributor

@zeldrisho zeldrisho commented Oct 2, 2025

Closes #11540

Closes Stremio/stremio-service/issues/45

scoop bucket add zeldrisho https://github.com/zeldrisho/scoop-bucket
scoop install zeldrisho/stremio-service

Summary by CodeRabbit

  • New Features
    • Adds Stremio Service as a new Windows installable package.
    • Supports silent and custom-directory installations.
    • Installer manages shortcuts (adds UI shortcuts; removes unnecessary Start Menu/Desktop entries after install).
    • Tracks releases on GitHub for automatic version checks and updates.
    • Verifies downloads with SHA-256 for integrity.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2025

All changes look good.

Wait for review from human collaborators.

stremio-service

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Check the full log for details.

@coderabbitai
Copy link

coderabbitai bot commented Oct 2, 2025

Walkthrough

Adds a new Scoop manifest bucket/stremio-service.json defining Stremio Service v0.1.14 for Windows: metadata, download URL and SHA-256, installer arguments, post-install shortcut cleanup, shortcuts mapping, GitHub checkver, and autoupdate template.

Changes

Cohort / File(s) Summary of Changes
New Scoop manifest
bucket/stremio-service.json
Added manifest for Stremio Service v0.1.14 with metadata (description, homepage, license), download URL and SHA-256, installer args (silent/dir), post_install removal of Start Menu/Desktop shortcuts, shortcuts mapping, checkver using GitHub releases, and autoupdate URL template.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • aliesbelik
  • z-Fng

Poem

I twitch my ears—new manifest bound,
A tiny installer hops around.
Shortcuts pruned and updates set,
Silent steps with no regret.
In the bucket’s burrow, joy is found. 🐇

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "stremio-service: Add version 0.1.14" clearly describes the main change in the changeset, which is the addition of a new JSON manifest for stremio-service version 0.1.14 to the bucket. The title follows the conventional format and is concise and specific enough that a teammate scanning history would immediately understand the primary change. There are no misleading or vague elements in the title.
Linked Issues Check ✅ Passed The pull request fulfills the requirements from linked issue #11540. The manifest includes all necessary components: version 0.1.14 metadata, a properly formatted JSON structure for the Windows installer, download URL with SHA-256 hash for integrity verification, and standard installer configuration. The post-install script to manage shortcuts is a reasonable and fairly standard approach for Windows package management. The manifest also includes checkver and autoupdate configuration to track GitHub releases, enabling future version management. All coding-related acceptance criteria from the linked issues are met.
Out of Scope Changes Check ✅ Passed The pull request contains only a single file addition: bucket/stremio-service.json, which is directly aligned with the requirements specified in the linked issues. The new manifest file is a straightforward addition to fulfill the package request for stremio-service version 0.1.14. There are no tangential changes, modifications to unrelated files, or additions beyond the scope of adding the requested package to the bucket.
Description Check ✅ Passed The pull request description includes most of the key required elements from the template: it references closed issues (#11540 and Stremio/stremio-service/issues/45) and includes a checked confirmation that the contributor has read the Contributing Guide. The PR title also follows the conventional format specified in the template. However, the "Use conventional PR title" checkbox remains unchecked in the description, though the actual title meets the conventional format requirement. Overall, the description contains the substantive required information and is sufficiently complete for review.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e55bcd1 and b7e0c18.

📒 Files selected for processing (1)
  • bucket/stremio-service.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • bucket/stremio-service.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: WindowsPowerShell

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fc1315f and e55bcd1.

📒 Files selected for processing (1)
  • bucket/stremio-service.json (1 hunks)

"/DIR=\"$dir\""
]
},
"post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\"",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Harden shortcut cleanup against missing targets.

Remove-Item throws when a shortcut is already gone (e.g., on upgrade), which turns the Scoop post_install step into a failure. Add -ErrorAction SilentlyContinue (and optionally -Force) so the cleanup stays idempotent. For example:

-"post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\"",
+"post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\" -ErrorAction SilentlyContinue -Force",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\"",
"post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\" -ErrorAction SilentlyContinue -Force",
🤖 Prompt for AI Agents
In bucket/stremio-service.json around line 14, the Remove-Item call in
post_install will throw if a shortcut is already missing and cause the step to
fail; update the command to make cleanup idempotent by adding -ErrorAction
SilentlyContinue (and -Force if desired) to each Remove-Item invocation so
missing targets do not raise errors and the post_install succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Request]: stremio-service Add it in Scoop bucket

1 participant