-
Couldn't load subscription status.
- Fork 1.5k
stremio-service: Add version 0.1.14 #16259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
All changes look good. Wait for review from human collaborators. stremio-service
|
WalkthroughAdds a new Scoop manifest Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bucket/stremio-service.json
Outdated
| "/DIR=\"$dir\"" | ||
| ] | ||
| }, | ||
| "post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Harden shortcut cleanup against missing targets.
Remove-Item throws when a shortcut is already gone (e.g., on upgrade), which turns the Scoop post_install step into a failure. Add -ErrorAction SilentlyContinue (and optionally -Force) so the cleanup stays idempotent. For example:
-"post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\"",
+"post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\" -ErrorAction SilentlyContinue -Force",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\"", | |
| "post_install": "Remove-Item \"$env:APPDATA\\Microsoft\\Windows\\Start Menu\\Programs\\Stremio Service.lnk\", \"$env:USERPROFILE\\Desktop\\Stremio Service.lnk\" -ErrorAction SilentlyContinue -Force", |
🤖 Prompt for AI Agents
In bucket/stremio-service.json around line 14, the Remove-Item call in
post_install will throw if a shortcut is already missing and cause the step to
fail; update the command to make cleanup idempotent by adding -ErrorAction
SilentlyContinue (and -Force if desired) to each Remove-Item invocation so
missing targets do not raise errors and the post_install succeeds.
Closes #11540
Closes Stremio/stremio-service/issues/45
Summary by CodeRabbit