Skip to content

Conversation

@SindriFr
Copy link

PR Info

New Features

  • Add support for postgres point type via sqlx::postgres::types::PgPoint

Breaking Changes

No breaking changes that I am aware of

@SindriFr SindriFr force-pushed the feat/support-postgres-point-type branch from 4987081 to 77528da Compare July 21, 2025 09:35
@tyt2y3 tyt2y3 changed the base branch from master to 0.32.x August 3, 2025 22:41
@tyt2y3 tyt2y3 changed the base branch from 0.32.x to master August 3, 2025 22:43
@tyt2y3
Copy link
Member

tyt2y3 commented Aug 3, 2025

sorry, recently there's a lot of changes on master. can you cherry-pick your commit to merge into 0.32.x?
I believe that's 77528da ?
sadly we can't depend on sqlx in the root crate, so we need to extract PgPoint to a third crate and perform conversion.

@SindriFr SindriFr force-pushed the feat/support-postgres-point-type branch from 77528da to dec9bd5 Compare August 5, 2025 15:57
@SindriFr
Copy link
Author

SindriFr commented Aug 5, 2025

sorry, recently there's a lot of changes on master. can you cherry-pick your commit to merge into 0.32.x? I believe that's 77528da ? sadly we can't depend on sqlx in the root crate, so we need to extract PgPoint to a third crate and perform conversion.

Certainly! Do you need me to do anything further?

@SindriFr
Copy link
Author

SindriFr commented Oct 2, 2025

@tyt2y3 You mentioned that sqlx should not be depended on by the root crate. I see that postgres_types (a dependency of sea-query) provides ToSql and FromSql implementations for geo-types Point, would you consider a merge of this branch if I used that instead?
I'd need to add geo-types 0.7 as an optional dependency as well as an optional feature flag in postgres_types when the point feature is enabled.

I've created an alternate PR (#992) with the proposed changes.

@SindriFr SindriFr changed the base branch from master to 0.32.x October 2, 2025 12:53
@SindriFr SindriFr force-pushed the feat/support-postgres-point-type branch from 555b092 to 2c83c50 Compare October 2, 2025 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support PostgreSQL 'point' type

2 participants