Skip to content

Conversation

@educasadei
Copy link
Contributor

This PR implements reading and writing unix permissions for LibArchive/Zip and the zip,unzip utilities.

@educasadei educasadei requested a review from timschumi as a code owner October 8, 2025 18:19
@BuggieBot
Copy link
Member

Hello!

One or more of the commit messages in this PR do not match the SerenityOS code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Oct 8, 2025
@educasadei educasadei force-pushed the zip-unix-permissions branch from 0ecae68 to fa3a34b Compare October 8, 2025 18:32
@educasadei educasadei force-pushed the zip-unix-permissions branch 3 times, most recently from d406ca1 to fca0486 Compare October 9, 2025 02:07
@educasadei educasadei requested a review from timschumi October 10, 2025 01:45
Copy link
Contributor

@nico nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Tim is on this, so I didn't look super closely, just one thing I noticed:

@educasadei educasadei force-pushed the zip-unix-permissions branch from fca0486 to ee9dccb Compare October 13, 2025 00:47
Implements reading and writing unix permissions for LibArchive/Zip and
the zip,unzip utilities.
@educasadei educasadei force-pushed the zip-unix-permissions branch from ee9dccb to 98f8795 Compare October 20, 2025 19:45
Copy link
Member

@timschumi timschumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, took a while to get back to this.

@timschumi timschumi merged commit 8abb480 into SerenityOS:master Oct 24, 2025
13 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants