Fix for Issue 2752 where blankrows:true skips first blank line #2815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 26, 2023 03:19
added code change to xlsx/flow using yarn lint as well
|
There seems to be plenty of test cases failing, please let me know if there is something specific that I'm doing wrong or is there some other reason itself! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to solve #2752 which is also mentioned in PR #2776 but it did not pass all tests of a PR as set by SheetJS.
This PR consists of two commits:
yarn lint, two other files were also updated, namelyxlsx.jsandxlsx.flow.js, which are also committed in this PR. These were missing in the code changes of PR fix #2752 sheet_to_csv skips first blank line with blankrows #2776 .Let's hope this time all tests cases are passed!