Bump @types/node from 20.12.5 to 24.2.1 #13986
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Open it as a draft if it’s a work in progress --> ### WHY are these changes introduced? 1. [PageActions](https://polaris-react.shopify.com/components/actions/page-actions) are a legacy UX solution. Page actions should instead be presented via the [contextual save bar](https://shopify.dev/docs/api/app-bridge-library/apis/save-bar) (in the case of Save) OR via the [Polaris Page](https://polaris-react.shopify.com/components/layout-and-structure/page) action props (i.e. `primaryAction`, `secondaryActions`, `actionGroups`). 2. [FullscreenBar](https://polaris-react.shopify.com/components/navigation/fullscreen-bar) is a legacy UX solution. Instead [max variant modals](https://shopify.dev/docs/api/app-bridge-library/web-components/ui-modal) should be used in combination with the [SaveBar](https://shopify.dev/docs/api/app-bridge-library/apis/save-bar) and [TitleBar](https://shopify.dev/docs/api/app-bridge-library/web-components/ui-title-bar). The [App Design Guidelines](https://shopify.dev/docs/apps/design/app-structure) explicitly state not to use FullscreenBar. <img width="840" height="324" alt="01-40-tyci1-sxt9y" src="https://github.com/user-attachments/assets/66ad93f8-9c08-44bc-8eba-03888ff834f6" /> Built for Shopify requirement [4.1.6](https://shopify.dev/docs/apps/launch/built-for-shopify/requirements#use-modals-appropriately), lists using FullscreenBar as a failure example. <img width="910" height="824" alt="01-43-t7px5-mzkqr" src="https://github.com/user-attachments/assets/503c87b1-910b-4003-a821-4b67b20a597d" /> <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? This PR moves both the `PageActions` and `FullscreenBar` components to the Deprecated section in the nav. It also displays a "Deprecated" banner on both of the component pages. <img width="1305" height="875" alt="01-59-c5awl-pclmj" src="https://github.com/user-attachments/assets/c5edc48b-aa77-4e33-ba95-a30c286308d0" /> <img width="1307" height="823" alt="01-58-qmsur-50290" src="https://github.com/user-attachments/assets/539050a1-89f3-4269-bd87-b8292e480bca" /> ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#install-dependencies-and-build-workspaces) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [x] Tested a [snapshot](https://github.com/Shopify/polaris/blob/main/documentation/Releasing.md#-snapshot-releases) - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.12.5 to 24.2.1. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 24.2.1 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
dependencies
|
A newer version of @types/node exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @types/node from 20.12.5 to 24.2.1.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)