add desired replication factor option #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to increase replication factor on a topic, besides moving partitions amond nodes
kanakb
suggested changes
Nov 3, 2016
| if (replicationFactor < 0) { | ||
| replicationFactor = replicas.size(); | ||
| } else { | ||
| } else if (desiredReplicationFactor<0) { |
There was a problem hiding this comment.
style nit: please add spaces on either side of the operator, i.e.
} else if (desiredReplicationFactor < 0) {
|
Thanks for the contribution! |
kanakb
approved these changes
Nov 3, 2016
|
This change (and this project in general) is very helpful. Would you consider uploading a new tarball release? |
|
Cool! FWIW I found #6 to be necessary as well. It's hard for me to believe that this isn't just how kafka-reassign-partitions.sh works by default! |
|
Hi @glasser, thanks for your interest in kafka-assigner! I have created a new release 1.1, which includes this PR. |
|
I will also release a 1.2 which includes #6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for situation in which you want to increase replication factor on a topic, besides moving partitions amond nodes