Automatic code generation for choreo #1298
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: ui
calcmogul
requested changes
Aug 21, 2025
There was a problem hiding this comment.
I don't have an opinion on the TypeScript implementation because I don't do webdev. However, I'm concerned about the added complexity and maintainability of this change. We already have to go through quite a few steps for schema upgrades, and this change adds more steps.
shueja
reviewed
Aug 21, 2025
| * This allows for modifying constants in choreo while keeping your robot code up-to-date. | ||
| * DO NOT MODIFY this file yourself, as it is auto-generated. | ||
| */ | ||
| public final class ChoreoConsts {`); |
There was a problem hiding this comment.
I suggest ChoreoRobotConfig.
Co-authored-by: Tyler Veness <[email protected]>
Co-authored-by: Tyler Veness <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choreo can now generate java files containing constants and variables defined in the GUI.
I decided to make the PR off the main branch instead of shueja's frontend-refactor, as the changes to the rest of the code are pretty minimal and (IMHO) can be integrated easily.