Modular Profiles: Gate HubCore 0.58 Release Required Logic #2350
Conversation
|
Invitation URL: |
Test Results 69 files 449 suites 0s ⏱️ For more details on these failures, see this check. Results for commit 89618f1. ♻️ This comment has been updated with latest results. |
|
matter-sensor_coverage.xml
matter-thermostat_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 89618f1 |
drivers/SmartThings/matter-sensor/src/air-quality-sensor/init.lua
Outdated
Show resolved
Hide resolved
| table.insert(total_supported_capabilities[MAIN_COMPONENT_IDX][CAPABILITIES_LIST_IDX], capabilities.firmwareUpdate.ID) | ||
|
|
||
| device:set_field(SUPPORTED_COMPONENT_CAPABILITIES, total_supported_capabilities, { persist = true }) | ||
| if version.api < 15 and version.rpc < 9 then |
There was a problem hiding this comment.
Could you add a brief comment indicating why this is needed and why we can't just rely on the the check for FW57 that is is done before calling into this function? Also could you create a ticket to eventually remove the old workaround entirely?
There was a problem hiding this comment.
Can you provide more detail in the "Summary of Completed Testing" section? One good test would be to do an A/B comparison between the subscription request that is sent out for a modular device with this change and without this change to confirm they are the same.
Also, could you test with a device that is onboarded to the existing production driver, then updates to this driver and confirm that the device sends out the correct subscription upon driver restart? It would be good to smoke test this case on 57 vs 58 FW versions.
| table.insert(total_supported_capabilities[MAIN_COMPONENT_IDX][CAPABILITIES_LIST_IDX], capabilities.refresh.ID) | ||
| table.insert(total_supported_capabilities[MAIN_COMPONENT_IDX][CAPABILITIES_LIST_IDX], capabilities.firmwareUpdate.ID) | ||
|
|
||
| device:set_field(SUPPORTED_COMPONENT_CAPABILITIES, total_supported_capabilities, { persist = true }) |
There was a problem hiding this comment.
We should be able to remove this table for drivers that no longer would need it after the hub updates to 58, right?
There was a problem hiding this comment.
that's true, table removal logic added in latest commit
Check all that apply
Type of Change
Checklist
Description of Change
Gate pre-0.58 logic for modular profiling. It is confirmed that these versions have been bumped in 0.58.
Summary of Completed Tests
Test Devices Used: VDA versions of all affected device types (Air Quality Sensor, Air Purifier, Thermostat, and Room Air Conditioner)
Tests Completed: