Skip to content

Conversation

hcarter-775
Copy link
Contributor

@hcarter-775 hcarter-775 commented Sep 4, 2025

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

The Matter subscribe logic will automatically subscribe a device to all attributes associated with a capability in a chosen profile if the associated cluster is included in the device, and this is not reset when a new profile is chosen. Therefore, using these larger lists of capabilities in the "generic" profiles is:

  1. leaving it more feasible that a device will not update for whatever reason and have unusable capabilities
  2. adding unnecessary attributes to an initial list of subscribed attributes which are never removed after the fact.

Summary of Completed Tests

Copy link

github-actions bot commented Sep 4, 2025

Copy link

github-actions bot commented Sep 4, 2025

Test Results

   69 files    449 suites   0s ⏱️
2 337 tests 2 337 ✅ 0 💤 0 ❌
3 930 runs  3 930 ✅ 0 💤 0 ❌

Results for commit d93a211.

Copy link

github-actions bot commented Sep 4, 2025

File Coverage
All files 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/embedded-cluster-utils.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 91%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against d93a211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant