Omit type conversion in AsRenderElements::render_elements() #1626
#1699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1626 This patch omits type conversion in `AsRenderElements::render_elements()` and simplifies it.
|
See also #1700. I prefer this (B) now as (C) has some issues. |
|
imo, this is the worst of both worlds, as we now have a guaranteed allocation. I think the issue of #1700 are fixable and the overall approach is simply better. |
|
Thanks! Let's continue discussion on #1700. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch omits type conversion in
AsRenderElements::render_elements()and simplifies it.Closes: #1626