Skip to content

fix: generate handler for each virtual keyboard. #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: generate handler for each virtual keyboard. #1801

wants to merge 1 commit into from

Conversation

Bot-wxt1221
Copy link

This fix the problem that all virtual keyboard share the same keymap.

@Bot-wxt1221
fix: generate handler for each virtual keyboard.
0550cb9 
This fix the problem that all virtual keyboard share the same keymap.
@Bot-wxt1221 Bot-wxt1221 marked this pull request as draft August 14, 2025 10:11
@Bot-wxt1221 Bot-wxt1221 marked this pull request as ready for review August 14, 2025 13:34
@Bot-wxt1221 Bot-wxt1221 mentioned this pull request Aug 20, 2025
Open
@Bot-wxt1221
Copy link
Author

None could review this?

kchibisov
kchibisov approved these changes Aug 22, 2025
View reviewed changes
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks fine, just by reading the code around it.

@Bot-wxt1221
Copy link
Author

So when to merge? Or any committer here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kchibisov kchibisov kchibisov approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bot-wxt1221 @kchibisov