Skip to content

MAC Address handling fixes for updates with netbox 4.2+ #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

MAC Address handling fixes for updates with netbox 4.2+ #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123753a
Normalize MAC addresses from netbox to lowercase
gs-adn Sep 11, 2025
780282d
Specify interface when assigning primary MAC address
gs-adn Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions netbox_agent/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,12 +294,12 @@ def update_interface_macs(self, nic, macs):
nb_macs = list(self.nb_net.mac_addresses.filter(interface_id=nic.id))
# Clean
for nb_mac in nb_macs:
if nb_mac.mac_address not in macs:
if nb_mac.mac_address.lower() not in macs:
logging.debug("Deleting extra MAC {mac} from {nic}".format(mac=nb_mac, nic=nic))
nb_mac.delete()
# Add missing
for mac in macs:
if mac not in {nb_mac.mac_address for nb_mac in nb_macs}:
if mac not in {nb_mac.mac_address.lower() for nb_mac in nb_macs}:
logging.debug("Adding MAC {mac} to {nic}".format(mac=mac, nic=nic))
self.nb_net.mac_addresses.create(
{
Expand Down Expand Up @@ -542,7 +542,7 @@ def batched(it, n):
if nic["mac"]:
self.update_interface_macs(interface, [nic["mac"]])

if nic["mac"] and nic["mac"] != interface.mac_address:
if nic["mac"] and nic["mac"] != interface.mac_address.lower():
logging.info(
"Updating interface {interface} mac to: {mac}".format(
interface=interface, mac=nic["mac"]
Expand All @@ -551,7 +551,12 @@ def batched(it, n):
if version.parse(nb.version) < version.parse("4.2"):
interface.mac_address = nic["mac"]
else:
interface.primary_mac_address = {"mac_address": nic["mac"]}
interface.primary_mac_address = {
"mac_address": nic["mac"],
"interface": {
"id": interface.id,
},
}
nic_update += 1

if hasattr(interface, "mtu"):
Expand Down