Skip to content

SLCORE-1427 Noisy analysis cancellation #1407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

SLCORE-1427 Noisy analysis cancellation #1407

wants to merge 1 commit into from

Conversation

kirill-knize-sonarsource
Copy link
Contributor

@kirill-knize-sonarsource kirill-knize-sonarsource commented Jul 4, 2025 •
edited by atlassian bot
Loading

@kirill-knize-sonarsource kirill-knize-sonarsource changed the base branch from master to feature/nq/SLCORE-1509-cancel-queued-task July 4, 2025 11:45
Base automatically changed from feature/nq/SLCORE-1509-cancel-queued-task to master July 4, 2025 11:55
@kirill-knize-sonarsource kirill-knize-sonarsource force-pushed the fix/kk/SLCORE-1427-Noisy-analysis-cancellation branch 5 times, most recently from 446ac5f to 4b978a3 Compare July 4, 2025 17:21
@kirill-knize-sonarsource kirill-knize-sonarsource force-pushed the fix/kk/SLCORE-1427-Noisy-analysis-cancellation branch from 4b978a3 to f28e581 Compare July 4, 2025 18:07
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Jul 4, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nquinquenel nquinquenel requested review from nquinquenel and removed request for nquinquenel July 7, 2025 07:41
@nquinquenel nquinquenel marked this pull request as draft July 9, 2025 06:48
@sonarqubecloud SonarQubeCloud
Copy link

🤖 Pull Request summary

Improves error handling for cancelled analysis operations.

• Refactored exception handling: Moved exceptionally block into the return chain for better flow control
• Added null check: Added validation to prevent processing null analysis results from cancelled operations
• Enhanced RPC error handling: Throws proper ResponseErrorException with cancellation error code when analysis results are null

Review focus: Verify that the null check properly handles all cancellation scenarios and doesn't inadvertently catch other failure modes that should return different errors.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirill-knize-sonarsource @nquinquenel