Scroll to a selected row in the table if a visible one is not already selected #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blsemo
reviewed
Feb 12, 2020
There was a problem hiding this comment.
What are we trying to achieve here? I am not sure that this behaviour is any better than the previous one - if I understand correctly, currently the table would stay at whatever position it was before this method was called - with this change, it would scroll to the next selected row, if there are rows selected and none visible after the redraw. I.e. if you select some rows and then hit sort, it would jump to wherever the first selected row ends up? That sounds more confusing to me than the current behaviour, tbh.
…nto table_scroll_to_selection
pklampros
force-pushed
the
table_scroll_to_selection
branch
from
e787f15 to
7cc3705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.