Add DisabledExtensions CA regsitry value

[JonasBK]

Description

The corresponding PR for this commonlib PR: SpecterOps/SharpHoundCommon#236

Motivation and Context

See commonlib PR.

How Has This Been Tested?

Locally.

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• Documentation updates are needed, and have been made accordingly.
• I have added and/or updated tests to cover my changes.
• All new and existing tests passed.
• My changes include a database migration.

Summary by CodeRabbit

• New Features
  • CA registry data now includes information about disabled extensions.
  • Added a new indicator to show whether disabled extensions have been collected.

[coderabbitai]

Walkthrough

A new boolean flag, disabledExtensionsCollected, is added to the ProcessEnterpriseCA method in ObjectProcessors.cs. The method now retrieves DisabledExtensions from the certificate abuse processor and includes both the property and its collection status in the CA registry data and properties dictionary.

Changes

Cohort / File(s)	Change Summary
CA Registry Data Collection Update src/Runtime/ObjectProcessors.cs	Added disabledExtensionsCollected flag and retrieval of DisabledExtensions in ProcessEnterpriseCA; updated CA registry data and properties dictionary to include this information.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant ObjectProcessors
    participant CertAbuseProcessor

    Caller->>ObjectProcessors: ProcessEnterpriseCA(dnsHostName, caName)
    ObjectProcessors->>CertAbuseProcessor: DisabledExtensions(dnsHostName, caName)
    CertAbuseProcessor-->>ObjectProcessors: DisabledExtensions data
    ObjectProcessors->>ObjectProcessors: Set disabledExtensionsCollected = true/false
    ObjectProcessors->>ObjectProcessors: Add DisabledExtensions to CARegistryData
    ObjectProcessors->>ObjectProcessors: Add "disabledextensionscollected" to ret.Properties
    ObjectProcessors-->>Caller: Return updated CARegistryData

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A flag for extensions, now gathered with care,
In the CA registry, new truths we declare.
With booleans and data, our logic extends—
The rabbit hops forward, old code it amends.
Disabled or not, we now always know,
As ObjectProcessors let the new details show! 🐇

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 034cb0e and ecb3d0e.

📒 Files selected for processing (1)

• src/Runtime/ObjectProcessors.cs (4 hunks)

🔇 Additional comments (4)

src/Runtime/ObjectProcessors.cs (4)

725-725: LGTM!

The declaration of disabledExtensionsCollected follows the established pattern and naming convention used by other CA registry collection flags.

---

748-748: LGTM!

The DisabledExtensions property assignment follows the established pattern and uses consistent parameters with other CA registry data collection methods.

---

760-760: LGTM!

The collection status assignment for disabledExtensionsCollected follows the established pattern and occurs at the appropriate time after the CARegistryData object creation.

---

770-770: LGTM!

The addition of disabledExtensionsCollected to the properties dictionary follows the established pattern and uses consistent key naming convention with other collection flags.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch esc16

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.