Skip to content

Don't apply adaptive timeouts to LDAP queries #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2025
Merged

Don't apply adaptive timeouts to LDAP queries #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6328753
fix: Don't apply adaptive timeouts to LDAP queries
definitelynotagoblin Oct 6, 2025
77e8ca3
chore: Tuning Adaptive Timeout to be less aggressive overall
definitelynotagoblin Oct 10, 2025
a6366b5
Merge branch 'v4' into non-adaptive-timeout-ldaps
definitelynotagoblin Oct 10, 2025
aacaeb7
Merge branch 'v4' into non-adaptive-timeout-ldaps
definitelynotagoblin Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/CommonLib/AdaptiveTimeout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ public sealed class AdaptiveTimeout : IDisposable {
private int _timeSpikeDecay;
private const int TimeSpikePenalty = 2;
private const int TimeSpikeForgiveness = 1;
private const int TimeSpikeThreshold = 5;
private const int TimeSpikeThreshold = 3;
private const int ExcessiveTimeoutsThreshold = 7;
private const int StdDevMultiplier = 5;
private const int CountOfLatestSuccessToKeep = 4;
private const int StdDevMultiplier = 7; // 7 standard deviations should be a very conservative upper bound
private const int CountOfLatestSuccessToKeep = 3;

public AdaptiveTimeout(TimeSpan maxTimeout, ILogger log, int sampleCount = 100, int logFrequency = 1000, int minSamplesForAdaptiveTimeout = 30, bool useAdaptiveTimeout = true, bool throwIfExcessiveTimeouts = false) {
if (maxTimeout <= TimeSpan.Zero)
Expand Down
6 changes: 3 additions & 3 deletions src/CommonLib/LdapConnectionPool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,9 @@ public LdapConnectionPool(string identifier, string poolIdentifier, LdapConfig c
_log = log ?? Logging.LogProvider.CreateLogger("LdapConnectionPool");
_portScanner = scanner ?? new PortScanner();
_nativeMethods = nativeMethods ?? new NativeMethods();
_queryAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapQuery"));
_pagedQueryAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapPagedQuery"));
_rangedRetrievalAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapRangedRetrieval"));
_queryAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapQuery"), useAdaptiveTimeout: false);
_pagedQueryAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapPagedQuery"), useAdaptiveTimeout: false);
_rangedRetrievalAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("LdapRangedRetrieval"), useAdaptiveTimeout: false);
_testConnectionAdaptiveTimeout = new AdaptiveTimeout(maxTimeout: TimeSpan.FromMinutes(2), Logging.LogProvider.CreateLogger("TestLdapConnection"));
}

Expand Down
Loading