Pinned pymssql version to <=2.3.0 for Python 3.8 compatibility #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylan-bitovi
changed the title
Sanity test for 2.3.1 if working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent issue has popped up for the SQL pack which makes it uninstallable.
Changes have been pushed to the
pymssqlPython library which makes it incompatible with ST2 which is still on 3.8. Attempting to install the pack will fail at installing requirements as it will detect that pymssql version2.3.4is available, which it will attempt to use as it satisfies the current<3.0set inrequirements.txtdespite it not being compatible with Python 3.8.The last version which works is
2.3.0. Link to PyPi library for 2.3.3 showing Python 3.8 support has been removed. The current version of pymssql has actually already moved to 2.3.4.Trying to install the pack as is throws some gcc/Cython errors. I tried investigating it some but the only thing I found that did work was cloning the repo and pinning the version to
2.3.0in requirements.txt myself and installing from my pack.Steps to reproduce:
sqlexchange pack using either the UI orst2 pack install sqlfrom the command line.Changes made:
requirements.txt- changedpymssqlversion from<3.0to<=2.3.0