Skip to content

Conversation

jk464
Copy link
Contributor

@jk464 jk464 commented May 20, 2024

As per https://github.com/instrumenta/kubeval/blob/master/README.md - kubeval is deprecated, and the recommended replacement is kubeconform.

This PR replaces our use of kubeval in the CI k8s-lint step with kubeconform.

Implementation is done using the helm plugin provided here https://github.com/jtyr/kubeconform-helm.

Justification for moving, aside from the deprecation, is the likes of #401 - where we could potentially add the use of 3rd party k8s modules(?), like cert-manager.

kubeconform makes it very easy to validate these 3rd party additions by simply passing https://raw.githubusercontent.com/datreeio/CRDs-catalog/main/{{.Group}}/{{.ResourceKind}}_{{.ResourceAPIVersion}}.json as a schema location

@pull-request-size pull-request-size bot added the size/S PR that changes 10-29 lines. Very easy to review. label May 20, 2024
@jk464 jk464 force-pushed the feature/kubeconform branch from 6488553 to e108010 Compare May 20, 2024 20:03
@jk464 jk464 requested a review from cognifloyd May 20, 2024 20:04
@jk464 jk464 force-pushed the feature/kubeconform branch from e108010 to 5de9772 Compare May 20, 2024 20:12
@cognifloyd cognifloyd enabled auto-merge (squash) May 21, 2024 00:04
@cognifloyd
Copy link
Member

LGTM. Would you please deal with the changelog conflict? Then it should auto merge.

auto-merge was automatically disabled May 21, 2024 09:35

Head branch was pushed to by a user without write access

@jk464 jk464 force-pushed the feature/kubeconform branch 2 times, most recently from c88a86b to ce56060 Compare May 21, 2024 10:34
@jk464 jk464 force-pushed the feature/kubeconform branch from ce56060 to 5a27fd5 Compare May 21, 2024 11:23
@jk464
Copy link
Contributor Author

jk464 commented May 21, 2024

@cognifloyd you'll need to merge manually - sadly auto-merge was disabled when I pushed to the branch:

auto-merge was automatically disabled May 21, 2024 10:35
Head branch was pushed to by a user without write access

@cognifloyd cognifloyd merged commit a7679c0 into StackStorm:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S PR that changes 10-29 lines. Very easy to review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants