Skip to content

SQGTurb debugging and various other fixes #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

SQGTurb debugging and various other fixes #73

wants to merge 18 commits into from

Conversation

@kysolvik
Copy link
Collaborator

@kysolvik kysolvik commented Jun 5, 2025

Started out as fixes to make sqgturb work, but that uncovered some other issues that I fixed along the way. In all:

  • sqgturb and pyqg_jax now produce xarray datasets (fixes Remaining issues from PR #56 #57)
  • Enables nearest-neighbor observation selection
  • Fixes observation sampling for multi-dimensional dataset
  • Makes DA cycler work with multi-variable datasets (see _rebuild_dataset() method in _dacycler.py)
  • Adds hybrid gain DA method
  • Various other fixes, mostly to make observers and da cyclers work better for datasets with different dimensions, number of variables, etc.

kysolvik added 18 commits May 5, 2025 10:18
@kysolvik
sqgturb tracer error fix: delta_t shouldn't be traced, messes up even…
bdc477b 
…tual xarray dataset building
@kysolvik
Remove static B covariance arg from etkf
d5a43d0
@kysolvik
Move var3d analysis computation to separate function
b7bfc2a
@kysolvik
New hybrid gain DA method
96526aa
@kysolvik
Enable nearest obs selection and fix multi-dimensional selection (wit…
e60ec44 
…hout replacement)
@kysolvik
Fixing multi-dim sampling for nonstationary sampler
fbdd867
@kysolvik
Observer separate case for non-stationary but regular (same num per t…
a9c5d0a 
…imestep) locations
@kysolvik
observer fix: use dims not coords att for finding nontime dimensions,…
d074eb4 
… and make system_dim consistently include all variables (not sure if this is the best way)
@kysolvik
Add _rebuild_dataset to properly reconscutrct multi-variable datasets…
a8fc313 
…, and allow obs_error_sd to be array
@kysolvik
3D-Var and ETKF: fix H shape, obs_error_sd array support, and use reb…
75674fc 
…uild dataset
@kysolvik
4D-Var and Backprop: Support array obs_error_sds (warning message for…
6c42136 
… non-stationary observers, may not function), and fix issues with multi-dimensional datasets
@kysolvik
Fixes for dimension issues in xarray accessors
c941404
@kysolvik
Pyqg jax with xarray output
c6a3410
@kysolvik
sqturb with proper xarray outputs
e7ca104
@kysolvik
Remove defaults from obs_error_sd and analysis_window
86e32e7
@kysolvik
Var3d test fix to include obs_error_sd, which is now required arg for…
943fce4 
… cycle()
@kysolvik
Observation sampling was updated to fix multi-dim problems, broke the…
6eb5aeb 
… tests
@kysolvik
Sqgturb generate produces exactly n_steps now, not n_steps+1, in orde…
b2930fe 
…r to match other generators
@kysolvik kysolvik mentioned this pull request Jun 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remaining issues from PR #56

2 participants

@kysolvik