Show internal gitlab reference warning #3845
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
client/src/features/ProjectPageV2/ProjectPageHeader/ProjectGitLabWarnBanner.tsx
Fixed
Show fixed
Hide fixed
client/src/features/ProjectPageV2/ProjectPageHeader/ProjectGitLabWarnBanner.tsx
Fixed
Show fixed
Hide fixed
ciyer
force-pushed
the
ciyer/gitlab-warning
branch
3 times, most recently
from
56cd45d to
ffcf464
Compare
|
You can access the deployment of this PR at https://renku-ci-ui-3845.dev.renku.ch |
ciyer
force-pushed
the
ciyer/gitlab-warning
branch
8 times, most recently
from
48e7dc5 to
7a187af
Compare
ciyer
changed the title
ciyer
force-pushed
the
ciyer/gitlab-warning
branch
from
7a187af to
22a6979
Compare
client/src/features/legacy/index.tsx
Outdated
There was a problem hiding this comment.
I would rather remove this file then. Though I don't understand why the original file is not kept.
There was a problem hiding this comment.
I started adding more components to this module, and I found that the one file was becoming unwieldy.
There was a problem hiding this comment.
I think I would much prefer sticking to our coding guideline then: export one component per file (https://github.com/SwissDataScienceCenter/renku-ui/wiki/Develop#r004-include-a-default-export-when-appropriate).
Then remove this index.tsx file and update the imports.
ciyer
force-pushed
the
ciyer/gitlab-warning
branch
from
22a6979 to
ac6d05d
Compare
ciyer
force-pushed
the
ciyer/gitlab-warning
branch
from
0a968e9 to
2351d86
Compare
client/src/features/legacy/index.tsx
Outdated
There was a problem hiding this comment.
I think I would much prefer sticking to our coding guideline then: export one component per file (https://github.com/SwissDataScienceCenter/renku-ui/wiki/Develop#r004-include-a-default-export-when-appropriate).
Then remove this index.tsx file and update the imports.
Co-authored-by: Flora Thiebaut <[email protected]>
|
Tearing down the temporary RenkuLab deplyoment for this PR. |
Show a warning on the project page if the internal GitLab is referenced by a code repository or session environment.
Testing
Create a Renku project (V2) and add a session launcher that references an image in the renkulab image repository (registry.renkulab.io) or a repo that points to the renkulab gitlab gitlab.renkulab.io (or both). Then you will see a warning.
/deploy