Skip to content

Conversation

m0sviatoslav
Copy link

No description provided.

@Zales0123
Copy link
Contributor

Hello @m0sviatoslav and thank you for your contribution! From the technical point of view, it totally makes sense, as we lower the amount of duplicated prefixes and therefore an amount of code.
However, as we use a Symfony Flex during the plugin installation, the src/Resources/config/app/routing.yml file is imported directly to the application. This change would require from us to add an admin/ prefix in a plugin recipe and to mention it in the installation process without a Symfony Flex. In the end, if someone would miss it, it would be possible to have strictly-admin routes imported... without an admin/ prefix :)

I would say the best option to throw out all admin-panel related routes to a separated yaml and import it in the main routing file. Therefore we would have 3 imports in a routing.yaml: new sylius_admin_order_creation: (or sth similar), sylius_admin_order_creation_ajax and fos_js_routing.

What do you think about it? Are you willing to introduce these changes? 🖖

@Zales0123 Zales0123 added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). and removed enhancement labels May 29, 2019
@htaoufikallah
Copy link

@Zales0123 I think that this PR should be reconsidered to support the new feature (%sylius_admin.path_name% ) in 1.8

Prometee pushed a commit to Prometee/AdminOrderCreationPlugin that referenced this pull request May 14, 2024
Prometee pushed a commit to Prometee/AdminOrderCreationPlugin that referenced this pull request May 14, 2024
Rename ".gitkeep" to ".gitignore"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants