This repository was archived by the owner on Oct 9, 2025. It is now read-only.
-
-
Couldn't load subscription status.
- Fork 53
Add customer address books in order creation view | Add webpack #184
Open
BartoszWojdalowicz
wants to merge
22
commits into
Sylius:main
Choose a base branch
from
BartoszWojdalowicz:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
611286d
add address book to create order form, include js and css files
BartoszWojdalowicz 309852e
Add webpack encore to plugin
c2d7ec8
Add built assets, change plugin name
1633e6e
edit templates
BartoszWojdalowicz 56d4561
add behat tests and modify existing
BartoszWojdalowicz 1896935
Improved: OrderPaymentLinkSender
igormukhingmailcom d0d34de
Shouldn't have payment limit on order
kayue cd3fa75
Remove useless Migrations step from README.md
8396442
[Maintenance] Drop support for PHP 7.4
GSadee 5ee743e
[Maintenance] Bump up support for Symfony 5 to 5.4 version
GSadee a929f1e
[Maintenance] Bump up node version in workflow
GSadee 7796e5f
[Maintenance] Drop support for Sylius 1.9 + add for Sylius 1.11
GSadee f0300f6
Replace Zend PriorityQueue with Laminas PriorityQueue
GSadee 8a516a8
[Maintenance] Add notes to UPGRADE file for 0.13.0
GSadee ab9353c
Fix state machine exception on order creation
maciekpaprocki 7b232c3
added phpspec tests
maciekpaprocki 8ae8979
Remove PHPUnit cache file
GSadee 6bb2396
Generate changelog for v0.13.0
GSadee aa83615
Merge branch 'master' into feature/address-book
BartoszWojdalowicz bf152d5
Merge pull request #1 from BartoszWojdalowicz/feature/address-book
BartoszWojdalowicz 5e7d64f
Merge branch 'master' of https://github.com/Sylius/AdminOrderCreation…
BartoszWojdalowicz 79e1b42
Merge branch 'master' of https://github.com/BartoszWojdalowicz/AdminO…
BartoszWojdalowicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
features/creating_order/creating_order_with_address_from_address_book.feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,48 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| @admin_order_creation_managing_orders | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Feature: Creating order with different billing address | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| In order to place an order in the name of a Customer | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| As an Administrator | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| I want to be able to create an order with different shipping and billing addresses in Admin panel | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Background: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Given the store operates on a single channel in "United States" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And the store has a product "Stark Coat" priced at "$100" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And the store has a product "Lannister Banner" priced at "$40" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And the store ships everywhere for free | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And the store allows paying with "Cash on Delivery" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And there is a customer account "[email protected]" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And their default address is "Ankh-Morpork", "Frost Alley", "90210", "United States" for "Jon Snow" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And this customer has an address "Ned Stark", "Banana Street", "90232", "New York", "United States" in their address book | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I am logged in as an administrator | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| @ui @javascript | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Scenario: Creating an order with both addresses from address books | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| When I create a new order for "[email protected]" and channel "United States" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I add "Stark Coat" to this order | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I see the address book shipping address select | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I see the address book billing address select | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I select first address in shipping address book with name "Jon Snow" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I select first address in billing address book with name "Ned Stark" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I select "Free" shipping method | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I select "Cash on Delivery" payment method | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I place and confirm this order | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Then I should be notified that order has been successfully created | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And this order shipping address should be "Jon Snow", "Frost Alley", "90210", "Ankh-Morpork", "United States" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And this order billing address should be "Ned Stark", "Banana Street", "90232", "New York", "United States" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And there should be one not paid nor shipped order with channel "United States" for "[email protected]" in the registry | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+19
to
+32
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
If we don't see the address book select field, we can't click it. So, in my opinion, these two steps seem redundant. Same below. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
| @ui @javascript | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Scenario: Creating an order with one address from address books | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| When I create a new order for "[email protected]" and channel "United States" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I add "Stark Coat" to this order | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I see the address book shipping address select | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I see the address book billing address select | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I specify this order shipping address as "Ankh-Morpork", "Frost Alley", "90210", "United States" for "Jon Snow" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I select first address in billing address book with name "Ned Stark" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I select "Free" shipping method | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I select "Cash on Delivery" payment method | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And I place and confirm this order | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Then I should be notified that order has been successfully created | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And this order billing address should be "Ned Stark", "Banana Street", "90232", "New York", "United States" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And this order shipping address should be "Jon Snow", "Frost Alley", "90210", "Ankh-Morpork", "United States" | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
| And there should be one not paid nor shipped order with channel "United States" for "[email protected]" in the registry | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,8 @@ Feature: Creating order with different billing address | |
| Scenario: Creating an order with both addresses specified | ||
| When I create a new order for "[email protected]" and channel "United States" | ||
| And I add "Stark Coat" to this order | ||
| And I should not see the address book shipping address select | ||
| And I should not see the address book billing address select | ||
|
Comment on lines
+20
to
+21
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not needed as well. If there's some kind of "wait" we should move it to the specify step. |
||
| And I specify this order shipping address as "Ankh-Morpork", "Frost Alley", "90210", "United States" for "Jon Snow" | ||
| And I specify this order billing address as "Rivendell", "Elm Street", "444", "United States" for "Ned Stark" | ||
| And I select "Free" shipping method | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "name": "@sylius/admin-order-creation-plugin", | ||
| "description": "Admin order creation plugin for Sylius.", | ||
| "repository": "https://github.com/Sylius/AdminOrderCreationPlugin.git", | ||
| "license": "MIT", | ||
| "scripts": { | ||
| "dist": "yarn encore production --config-name sylius-plugin-dist" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "entrypoints": { | ||
| "sylius-orderCreation-admin": { | ||
| "css": [ | ||
| "/build/sylius/orderCreation/admin/sylius-orderCreation-admin.css" | ||
| ], | ||
| "js": [ | ||
| "/build/sylius/orderCreation/admin/sylius-orderCreation-admin.js" | ||
| ] | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "build/sylius/orderCreation/admin/sylius-orderCreation-admin.css": "/build/sylius/orderCreation/admin/sylius-orderCreation-admin.css", | ||
| "build/sylius/orderCreation/admin/sylius-orderCreation-admin.js": "/build/sylius/orderCreation/admin/sylius-orderCreation-admin.js" | ||
| } |
10 changes: 10 additions & 0 deletions
10
public/build/sylius/orderCreation/admin/sylius-orderCreation-admin.css
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be
^5.4 || ^6.0