fix: swap virtual size and size of raw data #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techgeek1
added a commit
to EdenLabs/editpe
that referenced
this pull request
May 22, 2025
Integration of Systemcluster#1 from the parent repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about this at all, but I believe the VirtualSize should be the size of the data in memory and the SizeOfRawData should be the size of the raw data on the system. Additionally, I believe this should be a multiple of FileAlignment rather than section alignment.
https://learn.microsoft.com/en-us/windows/win32/debug/pe-format#section-table-section-headers
I have an issue where the outputted binary from this crate can't have a resource read from it until resaving the executable through Resource Hacker (this pr doesn't entirely fix that, but it seems to get the output closer to resource hacker).