Skip to content

Conversation

jaapio
Copy link
Contributor

@jaapio jaapio commented Sep 12, 2025

Other than what we did before we do now a full overwrite of the run command. This allows us to remove a number of less optimal constructions in the command. The change itself is empowered by the changes in phpdocumentor/guides-cli 1.9 which now provides a number of helper classes to simplify self build run commands.

@jaapio jaapio self-assigned this Sep 12, 2025
@jaapio jaapio force-pushed the task/cleanup-run-command branch 4 times, most recently from ca9d783 to 6d90087 Compare September 12, 2025 14:25
Other than what we did before we do now a full overwrite of the run command.
This allows us to remove a number of less optimal constructions in the command.
The change itself is empowered by the changes in phpdocumentor/guides-cli 1.9 which
now provides a number of helper classes to simplify self build run commands.
@jaapio jaapio force-pushed the task/cleanup-run-command branch from 6d90087 to 74267b7 Compare September 12, 2025 14:27
Copy link
Member

@linawolf linawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we should definately try this out!

@garvinhicking
Copy link
Contributor

We will hold off merging this for a short time to first have a stable release, and then integrate this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants