Fix the framework order for each continuous benchmarking run #10109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable values used by system services are not persistent, so any changes to them are lost after services finish execution. As a result, the framework order was not toggled properly after each continuous benchmarking run completed. Instead, use a regular file to keep track of the order. Signed-off-by: Anton Kirilov <[email protected]>
volyrique
force-pushed
the
continuous-benchmarking
branch
from
6fac2a1 to
7a388bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The environment variable values used by system services are not persistent, so any changes to them are lost after services finish execution. As a result, the framework order was not toggled properly after each continuous benchmarking run completed. Instead, use a regular file to keep track of the order.
This is another attempt to fix the framework order after pull request #9103. Of course, the copy of the respective script in the Citrine environment would have to be updated if my changes are acceptable; fortunately, there shouldn't be any need to interrupt a run to this end.