Skip to content

When testing in parallel, ignore orphaned child pids. #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

When testing in parallel, ignore orphaned child pids. #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50c32de
When testing in parallel, ignore orphaned child pids.
mvsjes2 Apr 1, 2024
20f3a16
Fix up precious failures.
mvsjes2 Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions lib/Test/Class/Moose/Executor/Parallel.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,9 @@ sub _test_class_is_parallelizable {
$_,
'noparallel'
);
}
$self->_test_methods_for($test_class);
}

$self->_test_methods_for($test_class);
}

sub _run_test_classes_in_parallel {
Expand All @@ -116,15 +117,28 @@ sub _run_test_classes_in_parallel {
}

# This chunk of code only runs in child processes
my $child_pid = $$;

my $class_report;
$subtest->attach($id);
$subtest->run(
sub {
$class_report = $self->run_test_class($test_class);
}
);
$subtest->detach;
$self->_fork_manager->finish( 0, \$class_report );

# if the test class also creates forks, and one of those forks dies,
# the dead child ends up running here, and causes subsequent problems
# with Test2::AsyncSubtest::detach, and can potentially cascade into
# all kinds of other problems during global destruction. i have no
# idea how a grandchild death can end up running this code...
if ( $$ == $child_pid ) {
$subtest->detach;
$self->_fork_manager->finish( 0, \$class_report );
}
else {
warn "Ignoring unknown child pid $$, did a grandchild pid die?";
}
}

$self->_fork_manager->wait_all_children;
Expand Down