some dependencies updated #390
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeplex-phpexcel-1.7.6
The following adjustments were made: - Files should end with a newline (PHP:S113) - Sections of code should not be commented out (PHP:S125) - Mergeable "if" statements should be combined (PHP:S1066) - Lines should not end with trailing whitespaces (PHP:S1131) - Unused local variables should be removed (PHP:S1481) - Identical expressions should not be used on both sides of a binary operator (PHP:S1764) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854)
The following adjustments were made: - Files should end with a newline (PHP:S113) - Mergeable "if" statements should be combined (PHP:S1066) - Empty statements should be removed (PHP:S1116) - Lines should not end with trailing whitespaces (PHP:S1131) - Unused function parameters should be removed (PHP:S1172) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854) - Two branches in a conditional structure should not have exactly the same implementation (PHP:S1871) - Array values should not be replaced unconditionally (PHP:S4143)
The following adjustments were made: - Files should end with a newline (PHP:S113) - Sections of code should not be commented out (PHP:S125) - Identical expressions should not be used on both sides of a binary operator (PHP:S1764) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Two branches in a conditional structure should not have exactly the same implementation (PHP:S1871) - Array values should not be replaced unconditionally (PHP:S4143)
The following adjustments were made: - Files should end with a newline (PHP:S113) - Unused local variables should be removed (PHP:S1481) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781)
The following adjustments were made: - Files should end with a newline (PHP:S113) - Mergeable "if" statements should be combined (PHP:S1066) - Redundant pairs of parentheses should be removed (PHP:1110) - Unused function parameters should be removed (PHP:S1172) - Unused local variables should be removed (PHP:S1481) - The "var" keyword should not be used (PHP:S1765) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781)
The following adjustments were made: - Files should end with a newline (PHP:S113) - Control structures should use curly braces (PHP:S121) - Non-empty statements should change control flow or have at least one side-effect (PHP:S905) - Mergeable "if" statements should be combined (PHP:S1066) - Unused "private" fields should be removed (PHP:S1068) - Redundant pairs of parentheses should be removed (PHP:1110) - Empty statements should be removed (PHP:S1116) - The "var" keyword should not be used (PHP:S1765)
The following adjustments were made: - Files should end with a newline (PHP:S113) - Empty statements should be removed (PHP:S1116) - Boolean literals should not be redundant (PHP:S1125) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854) - Unused local variables should be removed (PHP:S1481)
- Files should end with a newline (PHP:S113) - Empty statements should be removed (PHP:S1116) - Boolean literals should not be redundant (PHP:S1125) - Lines should not end with trailing whitespaces (PHP:S1131) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793)
The following adjustments were made: - Files should end with a newline (PHP:S113) - Mergeable "if" statements should be combined (PHP:S1066) - Empty statements should be removed (PHP:S1116) - Boolean literals should not be redundant (PHP:S1125) - Lines should not end with trailing whitespaces (PHP:S1131) - "empty()" should be used to test for emptiness (PHP:S1155) - Unused function parameters should be removed (PHP:S1172) - Unused local variables should be removed (PHP:S1481) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854) - "require_once" and "include_once" should be used instead of "require" and "include" (PHP:S2003)
The following adjustments were made: - Files should end with a newline (PHP:S113) - Control structures should use curly braces (PHP:S121) - Empty statements should be removed (PHP:S1116) - Unused function parameters should be removed (PHP:S1172) - Unused local variables should be removed (PHP:S1481) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - "require_once" and "include_once" should be used instead of "require" and "include" (PHP:S2003) - Unnecessary parentheses should not be used for constructs (PHP:S6600)
The following adjustments were made: - Revision of the parentheses for csv output
The following adjustments were made: - Files should end with a newline (PHP:S113) - Sections of code should not be commented out (PHP:S125) - Boolean literals should not be redundant (PHP:S1125) - Lines should not end with trailing whitespaces (PHP:S1131) - Unused local variables should be removed (PHP:S1481) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793)
- Line 403 and Line 385
The following adjustments were made: - Files should end with a newline (PHP:S113) - Sections of code should not be commented out (PHP:S125) - Mergeable "if" statements should be combined (PHP:S1066) - Boolean literals should not be redundant (PHP:S1125) - Lines should not end with trailing whitespaces (PHP:S1131) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Boolean checks should not be inverted (PHP:S1940) - Jump statements should not be redundant (PHP:S3626) - Unnecessary parentheses should not be used for constructs (PHP:6600)
The following adjustments were made: - Nested blocks of code should not be left empty (PHP:108) - Files should end with a newline (PHP:S113) - Sections of code should not be commented out (PHP:S125) - Mergeable "if" statements should be combined (PHP:S1066) - Redundant pairs of parentheses should be removed (PHP:1110) - Boolean literals should not be redundant (PHP:S1125) - Lines should not end with trailing whitespaces (PHP:S1131) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - Method visibility should be explicitly declared (PHP:S1784) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Array values should not be replaced unconditionally (PHP:S4143) - "default" clauses should be first or last (PHP:S4524)
The following adjustments were made: - Sections of code should not be commented out (PHP:S125) - Switch cases should end with an unconditional "break" statement (PHP:S128) - Lines should not end with trailing whitespaces (PHP:S1131) - Unused local variables should be removed (PHP:S1481) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - Method visibility should be explicitly declared (PHP:S1784) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854) - debug message unified
The following adjustments were made: - Mergeable "if" statements should be combined (PHP:S1066) - Lines should not end with trailing whitespaces (PHP:S1131) - Identical expressions should not be used on both sides of a binary operator (PHP:S1764) - The "var" keyword should not be used (PHP:S1765) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - Method visibility should be explicitly declared (PHP:S1784) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854)
line 1175 and line 1202
line 1519, line 2004 and line 2012
on line 305, 492, 688, 1987, 2573, 3270 and line 3336
The following adjustments were made: - Sections of code should not be commented out (PHP:S125) - Lines should not end with trailing whitespaces (PHP:S1131) - Unused local variables should be removed (PHP:S1481) - Unused assignments should be removed (PHP:S1854)
The following adjustments were made: - Formate source code - Remove trailing whitespaces - FIX Uncaught TypeError: count() - Tabulation characters should not be used (PHP:105) - Files should end with a newline (PHP:S113) - Mergeable "if" statements should be combined (PHP:S1066) - Modifiers should be declared in the correct order (PHP:S1124) - Boolean literals should not be redundant (PHP:S1125) - Use empty() to check whether the array is empty or not (PHP:S1155) - Unused local variables should be removed (PHP:S1481) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - Method visibility should be explicitly declared (PHP:S1784) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854) - Boolean checks should not be inverted (PHP:1940) - Jump statements should not be redundant (PHP:3626) - "default" clauses should be first or last (PHP:4524)
The following adjustments were made: - Formate source code - Remove trailing whitespaces - Files should end with a newline (PHP:S113) - Control structures should use curly braces (PHP:S121) - Sections of code should not be commented out (PHP:S125) - Mergeable "if" statements should be combined (PHP:S1066) - Empty statements should be removed (PHP:S1116) - Modifiers should be declared in the correct order (PHP:S1124) - Boolean literals should not be redundant (PHP:S1125) - Use empty() to check whether the array is empty or not (PHP:S1155) - Unused function parameters should be removed (PHP:S1172) - Unused local variables should be removed (PHP:S1481) - Local variables should not be declared and then immediately returned or thrown (PHP:1488) - Method visibility should be explicitly declared (PHP:S1784) - The "var" keyword should not be used (PHP:S1765) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854) - Jump statements should not be redundant (PHP:3626)
The following adjustments were made: - Formate source code - Control structures should use curly braces (PHP:S121) - Mergeable "if" statements should be combined (PHP:S1066) - Redundant pairs of parentheses should be removed (PHP:1110) - Boolean literals should not be redundant (PHP:S1125) - Return of boolean expressions should not be wrapped into an "if-then-else" statement (PHP:S1126) - Use empty() to check whether the array is empty or not (PHP:S1155) - Unused local variables should be removed (PHP:S1481) - Local variables should not be declared and then immediately returned or thrown (PHP:1488) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - Unused assignments should be removed (PHP:S1854) - "&&" and "||" should be used (PHP:S2010) - Unnecessary parentheses should not be used for constructs (PHP:S6600)
The following adjustments were made: - Formate source code - Files should end with a newline (PHP:S113) - Control structures should use curly braces (PHP:S121) - Sections of code should not be commented out (PHP:S125) - Mergeable "if" statements should be combined (PHP:S1066) - Empty statements should be removed (PHP:S1116) - Boolean literals should not be redundant (PHP:S1125) - Lines should not end with trailing whitespaces (PHP:S1131) - Use empty() to check whether the array is empty or not (PHP:S1155) - Unused local variables should be removed (PHP:S1481) - Local variables should not be declared and then immediately returned or thrown (PHP:1488) - Deprecated constructor declarations should not be used (PHP:S1603) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - "require_once" and "include_once" should be used instead of "require" and "include" (PHP:S2003) - Unnecessary parentheses should not be used for constructs (PHP:S6600)
The following adjustments were made: - Control structures should use curly braces (PHP:S121) - Mergeable "if" statements should be combined (PHP:S1066) - Redundant pairs of parentheses should be removed (PHP:1110) - Unused local variables should be removed (PHP:S1481) - Local variables should not be declared and then immediately returned or thrown (PHP:S1488) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - Unused assignments should be removed (PHP:S1854) - The "print" statement should not be used (python:PrintStatementUsage)
The following adjustments were made: - Permissions adjusted
The following adjustments were made: - Formate source code - Permissions revised - Sections of code should not be commented out (PHP:S125) - Mergeable "if" statements should be combined (PHP:S1066) - Unused local variables should be removed (PHP:S1481) - Local variables should not be declared and then immediately returned or thrown (PHP:1488) - Identical expressions should not be used on both sides of a binary operator (PHP:S1764) - Attributes deprecated in HTML5 should not be used (PHP:S1827) - Unused assignments should be removed (PHP:S1854) - "default" clauses should be first or last (PHP:4524)
The following adjustments were made: - Formate source code - Permissions revised - Local variable and function parameter names should comply with a naming convention (PHP:117) - Unused function parameters should be removed (PHP:S1172)
The following adjustments were made: - Formate source code - Permissions revised - Minor corrections - Switch cases should end with an unconditional "break" statement (PHP:128) - "switch" statements should have "default" clauses (PHP:131) - "switch" statements should have at least 3 "case" clauses (PHP:1301)
The following adjustments were made: - Long array to short array (LongArrayToShortArrayRector) - Changes negate of empty comparison of nullable value to explicit === or !== compare (NullableCompareToNullRector) - Change if with isset and return to coalesce (IfIssetToCoalescingRector) - Change list() to array destruct (ListToArrayDestructRector) - Add explicit public method visibility (ExplicitPublicClassMethodRector) - Change property modifier from var to public (VarToPublicPropertyRector) - Wrap encapsed variables in curly braces (WrapEncapsedVariableInCurlyBracesRector) - Privatize getter of local property to property (PrivatizeLocalGetterToPropertyRector) - Change count array comparison to empty array comparison to improve performance (CountArrayToEmptyArrayComparisonRector) - Makes array_search search for identical elements (StrictArraySearchRector)
The following adjustments were made: - Split multiple inline assigns to each own lines default value, to prevent undefined array issues (SplitDoubleAssignRector) - Assign outcome of ternary condition to variable, where applicable (TernaryConditionVariableAssignmentRector) - Change array_push() to direct variable assign (ChangeArrayPushToArrayAssignRector) - Switch negated ternary condition rector (SwitchNegatedTernaryRector) - Change count() in for function to own variable (ForRepeatedCountToOwnVariableRector) - Make if conditions more explicit (ExplicitBoolCompareRector)
The following adjustments were made: - Simplify regex pattern to known ranges (SimplifyRegexPatternRector) - Return early prepared value in ifs (PreparedValueToEarlyReturnRector) - Change ternary of bool : false to && bool (TernaryToBooleanOrFalseToBooleanAndRector) - Replace if conditioned variable override with direct return (ReturnEarlyIfVariableRector) - Remove recasting of the same type (RecastingRemovalRector)
- FIX Undefined array key "addReporter" - in \lib\issuetrackerintegration\issueTrackerInterface.class.php - Line 382 - FIX Undefined array key "addHandler" - in \lib\issuetrackerintegration\issueTrackerInterface.class.php - Line 398 - FIX Undefined array key "platforms" - in \lib\functions\specview.php - Line 854 - FIX Trying to access array offset on value of type null - in \lib\functions\specview.php - Line 1232 - FIX Trying to access array offset on value of type null - in \lib\functions\specview.php - Line 1825 - FIX Undefined array key "bulk_tester_div" - in \lib\plan\tc_exec_assignment.php - Line 287 - FIX preg_match(): Compilation failed: missing terminating ] for character class at offset 33 - in \lib\results\tcCreatedPerUserOnTestProject.php - Line 455 - FIX Undefined property: stdClass::$row_qty - in \lib\requirements\reqSpecSearch.php - Line 138 - FIX Undefined array key "actions" - in \lib\functions\testcase.class.php - Line 8339 - FIX Undefined array key "actions" - in \lib\functions\testcase.class.php - Line 8340 - FIX Undefined array key "expected_results" - in \lib\functions\testcase.class.php - Line 8339 - FIX Undefined array key "expected_results" - in \lib\functions\testcase.class.php - Line 8340 - FIX Undefined property: stdClass::$createissueviaapi - in \lib\execute\execSetResults.php - Line 1667 - FIX Trying to access array offset on value of type bool - in \lib\requirements\reqSpecCommands.class.php - Line 212 - FIX Undefined array key 1 - in \lib\functions\testcase.class.php - Line 5665 - FIX Undefined array key 0 - in \lib\functions\testcase.class.php - Line 5667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
To clean up the code a bit, the no longer used dependency codeplex-phpexcel-1.7.6 was deleted. The last version of codeplex was implemented by Francisco in 2019.
Afterwards, a few other dependencies were updated to the latest version using Composer.
Best regards,
Dan