Protect upsert workers from input overload #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
upsert.rsoperator was doing non-trivial work as it read its input (inserting records into a priority queue). This has the potential to trap workers, who may not be able to retire input as fast as it is produced. Ideally, operators would take a fixed amount of input data (e.g. whatever is available when scheduled) and only do that work, rather than continuing to pull in new data as they run.This modification makes the workers just drain their inputs without performing work, and then insert the now bounded number of records into the priority queue.
cc: @cirego