honor max and min #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmcd
reviewed
Apr 30, 2021
| function filterRange(ip) { | ||
| assert.object(ip, "ip") | ||
|
|
||
| // We should show managed addresses |
There was a problem hiding this comment.
"Show" managed addresses, or "evaluate within" managed addresses? Not sure what's being shown here.
Or is this a TODO item you want to have happen later?
| } | ||
| if (ip.params.ip != null) { | ||
| Addr = util_ip.addressToNumber(ip.params.ip.toString()); | ||
| } |
There was a problem hiding this comment.
Are you guaranteed that Addr will be set when you reach here? (Pardon my JS lack of knowledge here... not knowing any better, it could be possible that "ipaddr" AND "ip" are both null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #25