Skip to content

Conversation

sharadregoti
Copy link
Contributor

@sharadregoti sharadregoti commented Sep 17, 2025

User description

Contributor checklist

  • Reviewed PR Code suggestions and updated accordingly
  • Tyklings: Labled the PR with the relevant releases
  • Tyklings: Added Jira DX PR ticket to the subject

New Contributors



PR Type

Documentation


Description

  • Clarify middleware configuration wording

  • Fix Traffic Transformation links and anchors

  • Remove outdated OSS qualifier for Operator

  • Minor formatting cleanup in config snippet


Diagram Walkthrough

flowchart LR
  classic["Classic middleware docs"] -- "clarify + link to pages" --> traffic["Traffic Transformation pages"]
  features["Gateway features include"] -- "update wording" --> operator["Tyk Operator link"]
  logs["Logs & metrics"] -- "formatting cleanup" --> snippet["Collector config snippet"]
Loading

File Walkthrough

Relevant files
Documentation
gateway-config-tyk-classic.md
Clarify middleware options and fix references                       

tyk-docs/content/api-management/gateway-config-tyk-classic.md

  • Reword middleware config explanation for clarity.
  • Add concrete refs to Traffic Transformation pages.
  • Specify Classic API Definition anchor.
  • Clarify mock response via allow/deny/ignore middleware.
+1/-4     
tyk-gateway-features-include.md
Update Tyk Operator wording in features                                   

tyk-docs/content/shared/tyk-gateway-features-include.md

  • Remove "Open Source" qualifier from Operator reference.
  • Keep direct link to Tyk Operator repository.
+1/-1     
Formatting
logs-metrics.md
Minor formatting cleanup in example                                           

tyk-docs/content/api-management/logs-metrics.md

  • Remove stray blank line in YAML example.
+0/-1     

Copy link
Contributor

⚠️ Deploy preview for PR #6949 did not become live after 3 attempts.
Please check Netlify or try manually: Preview URL

@github-actions github-actions bot changed the title [DX-2102] Docs Improvement [DX-2102] Docs Improvement Sep 17, 2025
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Link Accuracy

Validate that the Traffic Transformation and Classic API Definition anchors resolve correctly; the previous link was empty, so ensure these new refs point to the intended sections.

Each entry must include the method and path (identifying the endpoint) where the middleware runs. You can find the other options for each middleware on its respective [Traffic Transformation]({{< ref "api-management/traffic-transformation" >}}) page under the [Classic API Definition]({{< ref "api-management/traffic-transformation/allow-list#api-definition-1" >}}) section. The black_list[], white_list[], and ignore[] middleware provide mock response functionality.

Code Block Formatting

Confirm the fenced code block renders as intended after removing the blank line; ensure no unintended formatting regression in Markdown rendering.

        receivers: [otlp]
        processors: [batch]
        exporters: [datadog]
    ```

2. **Configure a test API**
Wording Consistency

Dropping the OSS qualifier may affect messaging; confirm this aligns with product positioning and that any references to OSS elsewhere remain consistent.

**Kubernetes native declarative API:** using [Tyk Operator](https://github.com/TykTechnologies/tyk-operator)

Copy link
Contributor

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Reinstate code formatting and accuracy

Restore code-style formatting for middleware and field names to avoid reader
confusion and potential docs linting failures. Also ensure internal ref targets are
accurate and resilient by linking to the section anchor that definitively exists.

tyk-docs/content/api-management/gateway-config-tyk-classic.md [163]

-Each entry must include the method and path (identifying the endpoint) where the middleware runs. You can find the other options for each middleware on its respective [Traffic Transformation]({{< ref "api-management/traffic-transformation" >}}) page under the [Classic API Definition]({{< ref "api-management/traffic-transformation/allow-list#api-definition-1" >}}) section. The black_list[], white_list[], and ignore[] middleware provide mock response functionality.
+Each entry must include the `method` and `path` (identifying the endpoint) where the middleware runs. You can find the other options for each middleware on its respective [Traffic Transformation]({{< ref "api-management/traffic-transformation" >}}) page under the [Classic API Definition]({{< ref "api-management/traffic-transformation/allow-list#api-definition-1" >}}) section. The `black_list[]`, `white_list[]`, and `ignore[]` middleware provide mock response functionality.
Suggestion importance[1-10]: 6

__

Why: Restoring backticks around method, path, and middleware names improves clarity and consistency in the docs. The change matches the new hunk line and is low risk but modest in impact.

Low
Add missing trailing newline

Ensure the file ends with a newline to avoid formatting issues and tooling warnings
in Markdown processors and linters. This prevents concatenation problems when
included in builds.

tyk-docs/content/shared/tyk-gateway-features-include.md [47]

 _...and everything else you expect from a Cloud Native API Gateway_
-\ No newline at end of file
Suggestion importance[1-10]: 4

__

Why: Ensuring a trailing newline is a minor but useful formatting fix that avoids linters/tooling warnings. It correctly targets the final line of the file in the new hunk.

Low

Copy link
Contributor

github-actions bot commented Sep 17, 2025

PR Review: DX-2102 Docs Improvement (PR #6949)

Summary

This PR appears to be a documentation improvement related to ticket DX-2102. However, the deploy preview for this PR has failed after 3 attempts, indicating there are issues that need to be addressed before it can be merged.

Critical Issues

The primary issue is that the Netlify deploy preview failed to build. This usually indicates one of the following problems:

  1. Hugo Build Errors: There might be syntax errors in the markdown files or issues with the Hugo templates.
  2. Broken Internal Links: The documentation might contain references to non-existent pages or sections.
  3. Invalid Front Matter: The YAML front matter at the top of markdown files might have formatting issues.
  4. Image Path Issues: Referenced images might have incorrect paths or be missing.

Recommendations

Since the deploy preview failed, I recommend the following steps:

  1. Run Hugo Locally: Before pushing changes, run Hugo locally to check for build errors:

    hugo server --theme=tykio --buildDrafts --enableGitInfo
    
  2. Check HTML Validation: Ensure all HTML in markdown files is properly formatted.

  3. Verify Internal Links: Make sure all internal links use the proper ref function format:

    [Link title]({{< ref "path-to-page" >}})
    
  4. Validate Image Paths: Ensure all images are in the assets/img folder and referenced correctly:

    {{< img src="/img/image-name.png" alt="Alt Text" >}}
    
  5. Check Front Matter: Ensure all markdown files have properly formatted front matter with required fields (title, date, description, tags).

  6. Try the Manual Preview: As suggested by the GitHub Actions bot, you can try to manually access the preview URL: Preview URL

Next Steps

  1. Fix the issues causing the deployment failure
  2. Push the changes to the PR branch
  3. Wait for the CI to run again and check if the deploy preview succeeds
  4. Complete the contributor checklist items in the PR description

Once these issues are resolved, the PR can be properly reviewed for content quality and accuracy.


Tip: Mention me again using /probe <request>.
Powered by Probe AI

Copy link

netlify bot commented Sep 17, 2025

PS. Add to the end of url /docs/nightly

Name Link
🔨 Latest commit 115231d
🔍 Latest deploy log https://app.netlify.com/projects/tyk-docs/deploys/68e51b96120ead0008991cdb
😎 Deploy Preview https://deploy-preview-6949--tyk-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sharadregoti sharadregoti changed the title [DX-2102] Docs Improvement [DX-2102] Bug Fixes and Improvements in Tyk OAS Sep 18, 2025
@sharadregoti
Copy link
Contributor Author

@andyo-tyk @lghiur once the changes are approved here, I'll raise a separate PR in the Tyk repository to update the OAS docs accordingly.

@sharadregoti sharadregoti merged commit b60f1d3 into master Oct 7, 2025
11 of 12 checks passed
@sharadregoti sharadregoti deleted the DX-2102 branch October 7, 2025 13:56
@sharadregoti
Copy link
Contributor Author

/release to release-5.8

@sharadregoti
Copy link
Contributor Author

/release to release-5.9

Copy link
Contributor

tykbot bot commented Oct 7, 2025

Working on it! Note that it can take a few minutes.

1 similar comment
Copy link
Contributor

tykbot bot commented Oct 7, 2025

Working on it! Note that it can take a few minutes.

tykbot bot pushed a commit that referenced this pull request Oct 7, 2025
* Fixes

* Update dashboard-configuration.md (#6941)

* Initial commit

* Fix

* Apply suggestions from code review

Co-authored-by: andyo-tyk <[email protected]>

* Apply suggestions from code review

Co-authored-by: andyo-tyk <[email protected]>

* Update tyk-docs/content/shared/x-tyk-gateway.md

Co-authored-by: andyo-tyk <[email protected]>

* Remove customplugins

---------

Co-authored-by: Sedky Haider <[email protected]>
Co-authored-by: Leonid Bugaev <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>

(cherry picked from commit b60f1d3)
Copy link
Contributor

tykbot bot commented Oct 7, 2025

@sharadregoti Created merge PRs

tykbot bot pushed a commit that referenced this pull request Oct 7, 2025
* Fixes

* Update dashboard-configuration.md (#6941)

* Initial commit

* Fix

* Apply suggestions from code review

Co-authored-by: andyo-tyk <[email protected]>

* Apply suggestions from code review

Co-authored-by: andyo-tyk <[email protected]>

* Update tyk-docs/content/shared/x-tyk-gateway.md

Co-authored-by: andyo-tyk <[email protected]>

* Remove customplugins

---------

Co-authored-by: Sedky Haider <[email protected]>
Co-authored-by: Leonid Bugaev <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>

(cherry picked from commit b60f1d3)
Copy link
Contributor

tykbot bot commented Oct 7, 2025

@sharadregoti Created merge PRs

buger added a commit that referenced this pull request Oct 7, 2025
…AS (#6949)

[DX-2102] Bug Fixes and Improvements in Tyk OAS (#6949)

* Fixes

* Update dashboard-configuration.md (#6941)

* Initial commit

* Fix

* Apply suggestions from code review

Co-authored-by: andyo-tyk <[email protected]>

* Apply suggestions from code review

Co-authored-by: andyo-tyk <[email protected]>

* Update tyk-docs/content/shared/x-tyk-gateway.md

Co-authored-by: andyo-tyk <[email protected]>

* Remove customplugins

---------

Co-authored-by: Sedky Haider <[email protected]>
Co-authored-by: Leonid Bugaev <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>
buger added a commit that referenced this pull request Oct 7, 2025
…AS (#6949)

[DX-2102] Bug Fixes and Improvements in Tyk OAS (#6949)

* Fixes

* Update dashboard-configuration.md (#6941)

* Initial commit

* Fix

* Apply suggestions from code review

Co-authored-by: andyo-tyk <[email protected]>

* Apply suggestions from code review

Co-authored-by: andyo-tyk <[email protected]>

* Update tyk-docs/content/shared/x-tyk-gateway.md

Co-authored-by: andyo-tyk <[email protected]>

* Remove customplugins

---------

Co-authored-by: Sedky Haider <[email protected]>
Co-authored-by: Leonid Bugaev <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>
lghiur pushed a commit to TykTechnologies/tyk that referenced this pull request Oct 7, 2025
### **User description**
<!-- Provide a general summary of your changes in the Title above -->

Improved Tyk OAS documentation as per the Jira
https://tyktech.atlassian.net/browse/DX-2102

Changes have already been added in the
[docs](TykTechnologies/tyk-docs#6949)

## Description

<!-- Describe your changes in detail -->

## Related Issue

<!-- This project only accepts pull requests related to open issues. -->
<!-- If suggesting a new feature or change, please discuss it in an
issue first. -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce. -->
<!-- OSS: Please link to the issue here. Tyk: please create/link the
JIRA ticket. -->

## Motivation and Context

<!-- Why is this change required? What problem does it solve? -->

## How This Has Been Tested

<!-- Please describe in detail how you tested your changes -->
<!-- Include details of your testing environment, and the tests -->
<!-- you ran to see how your change affects other areas of the code,
etc. -->
<!-- This information is helpful for reviewers and QA. -->

## Screenshots (if appropriate)

## Types of changes

<!-- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
- [ ] Refactoring or add test (improvements in base code or adds test
coverage to functionality)

## Checklist

<!-- Go over all the following points, and put an `x` in all the boxes
that apply -->
<!-- If there are no documentation updates required, mark the item as
checked. -->
<!-- Raise up any additional concerns not covered by the checklist. -->

- [ ] I ensured that the documentation is up to date
- [ ] I explained why this PR updates go.mod in detail with reasoning
why it's required
- [ ] I would like a code coverage CI quality gate exception and have
explained why


___

### **PR Type**
Documentation


___

### **Description**
- Clarify `Paths` key semantics and examples

- Document `Operations` keyed by `operationID`

- Expand `State.Internal` exposure behavior details

- Fix typo in `ListenPath` strip example


___

### Diagram Walkthrough


```mermaid
flowchart LR
  Paths["Paths docs"] -- clarify keys/examples --> Middleware["Middleware struct context"]
  Operations["Operations docs"] -- key is operationID --> Operation["Operation definition"]
  StateInternal["State.Internal docs"] -- detail exposure behavior --> GatewayExposure["Gateway exposure rules"]
  ListenPath["ListenPath docs"] -- fix URL typo --> Example["Strip path example"]
```



<details> <summary><h3> File Walkthrough</h3></summary>

<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Documentation</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>middleware.go</strong><dd><code>Clarify Paths map keys
and context</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

apidef/oas/middleware.go

<ul><li>Expand <code>Paths</code> comment with Middleware context<br>
<li> Explain string keys as URL patterns</ul>


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7419/files#diff-992ec7c28d25fd54f6491d295389757705cd114bc869a35cba50d42e548cdc6e">+2/-1</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>operation.go</strong><dd><code>Describe Operations
keyed by operationID</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; </dd></summary>
<hr>

apidef/oas/operation.go

- Document `Operations` map keyed by `operationID`


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7419/files#diff-6d92d2d5b09a5fa7129609bb7cd0d383d015250ec07062b6a93a83257be51fb5">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>root.go</strong><dd><code>Expand Internal field
exposure semantics</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; </dd></summary>
<hr>

apidef/oas/root.go

- Elaborate `State.Internal` behavior and references


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7419/files#diff-9c56b2bdb992e0a7db76809d4c516e1cd61c9486c7f0437b344c0032476af80f">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>

<tr>
  <td>
    <details>
<summary><strong>server.go</strong><dd><code>Fix ListenPath strip
example URL</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; </dd></summary>
<hr>

apidef/oas/server.go

- Fix base URL typo in strip example


</details>


  </td>
<td><a
href="https://github.com/TykTechnologies/tyk/pull/7419/files#diff-21857c42e8659f7980014e277c3c758703f29e9e5c0c40553f2584cddb870808">+1/-1</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>
</table></td></tr></tr></tbody></table>

</details>

___
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants