-
Notifications
You must be signed in to change notification settings - Fork 167
[DX-2102] Bug Fixes and Improvements in Tyk OAS #6949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
PR Review: DX-2102 Docs Improvement (PR #6949)SummaryThis PR appears to be a documentation improvement related to ticket DX-2102. However, the deploy preview for this PR has failed after 3 attempts, indicating there are issues that need to be addressed before it can be merged. Critical IssuesThe primary issue is that the Netlify deploy preview failed to build. This usually indicates one of the following problems:
RecommendationsSince the deploy preview failed, I recommend the following steps:
Next Steps
Once these issues are resolved, the PR can be properly reviewed for content quality and accuracy. Tip: Mention me again using |
✅ PS. Add to the end of url /docs/nightly
To edit notification comments on pull requests, go to your Netlify project configuration. |
@andyo-tyk @lghiur once the changes are approved here, I'll raise a separate PR in the Tyk repository to update the OAS docs accordingly. |
Co-authored-by: andyo-tyk <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>
/release to release-5.8 |
/release to release-5.9 |
Working on it! Note that it can take a few minutes. |
1 similar comment
Working on it! Note that it can take a few minutes. |
* Fixes * Update dashboard-configuration.md (#6941) * Initial commit * Fix * Apply suggestions from code review Co-authored-by: andyo-tyk <[email protected]> * Apply suggestions from code review Co-authored-by: andyo-tyk <[email protected]> * Update tyk-docs/content/shared/x-tyk-gateway.md Co-authored-by: andyo-tyk <[email protected]> * Remove customplugins --------- Co-authored-by: Sedky Haider <[email protected]> Co-authored-by: Leonid Bugaev <[email protected]> Co-authored-by: andyo-tyk <[email protected]> (cherry picked from commit b60f1d3)
@sharadregoti Created merge PRs |
* Fixes * Update dashboard-configuration.md (#6941) * Initial commit * Fix * Apply suggestions from code review Co-authored-by: andyo-tyk <[email protected]> * Apply suggestions from code review Co-authored-by: andyo-tyk <[email protected]> * Update tyk-docs/content/shared/x-tyk-gateway.md Co-authored-by: andyo-tyk <[email protected]> * Remove customplugins --------- Co-authored-by: Sedky Haider <[email protected]> Co-authored-by: Leonid Bugaev <[email protected]> Co-authored-by: andyo-tyk <[email protected]> (cherry picked from commit b60f1d3)
@sharadregoti Created merge PRs |
…AS (#6949) [DX-2102] Bug Fixes and Improvements in Tyk OAS (#6949) * Fixes * Update dashboard-configuration.md (#6941) * Initial commit * Fix * Apply suggestions from code review Co-authored-by: andyo-tyk <[email protected]> * Apply suggestions from code review Co-authored-by: andyo-tyk <[email protected]> * Update tyk-docs/content/shared/x-tyk-gateway.md Co-authored-by: andyo-tyk <[email protected]> * Remove customplugins --------- Co-authored-by: Sedky Haider <[email protected]> Co-authored-by: Leonid Bugaev <[email protected]> Co-authored-by: andyo-tyk <[email protected]>
…AS (#6949) [DX-2102] Bug Fixes and Improvements in Tyk OAS (#6949) * Fixes * Update dashboard-configuration.md (#6941) * Initial commit * Fix * Apply suggestions from code review Co-authored-by: andyo-tyk <[email protected]> * Apply suggestions from code review Co-authored-by: andyo-tyk <[email protected]> * Update tyk-docs/content/shared/x-tyk-gateway.md Co-authored-by: andyo-tyk <[email protected]> * Remove customplugins --------- Co-authored-by: Sedky Haider <[email protected]> Co-authored-by: Leonid Bugaev <[email protected]> Co-authored-by: andyo-tyk <[email protected]>
### **User description** <!-- Provide a general summary of your changes in the Title above --> Improved Tyk OAS documentation as per the Jira https://tyktech.atlassian.net/browse/DX-2102 Changes have already been added in the [docs](TykTechnologies/tyk-docs#6949) ## Description <!-- Describe your changes in detail --> ## Related Issue <!-- This project only accepts pull requests related to open issues. --> <!-- If suggesting a new feature or change, please discuss it in an issue first. --> <!-- If fixing a bug, there should be an issue describing it with steps to reproduce. --> <!-- OSS: Please link to the issue here. Tyk: please create/link the JIRA ticket. --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? --> ## How This Has Been Tested <!-- Please describe in detail how you tested your changes --> <!-- Include details of your testing environment, and the tests --> <!-- you ran to see how your change affects other areas of the code, etc. --> <!-- This information is helpful for reviewers and QA. --> ## Screenshots (if appropriate) ## Types of changes <!-- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Refactoring or add test (improvements in base code or adds test coverage to functionality) ## Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply --> <!-- If there are no documentation updates required, mark the item as checked. --> <!-- Raise up any additional concerns not covered by the checklist. --> - [ ] I ensured that the documentation is up to date - [ ] I explained why this PR updates go.mod in detail with reasoning why it's required - [ ] I would like a code coverage CI quality gate exception and have explained why ___ ### **PR Type** Documentation ___ ### **Description** - Clarify `Paths` key semantics and examples - Document `Operations` keyed by `operationID` - Expand `State.Internal` exposure behavior details - Fix typo in `ListenPath` strip example ___ ### Diagram Walkthrough ```mermaid flowchart LR Paths["Paths docs"] -- clarify keys/examples --> Middleware["Middleware struct context"] Operations["Operations docs"] -- key is operationID --> Operation["Operation definition"] StateInternal["State.Internal docs"] -- detail exposure behavior --> GatewayExposure["Gateway exposure rules"] ListenPath["ListenPath docs"] -- fix URL typo --> Example["Strip path example"] ``` <details> <summary><h3> File Walkthrough</h3></summary> <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Documentation</strong></td><td><table> <tr> <td> <details> <summary><strong>middleware.go</strong><dd><code>Clarify Paths map keys and context</code> </dd></summary> <hr> apidef/oas/middleware.go <ul><li>Expand <code>Paths</code> comment with Middleware context<br> <li> Explain string keys as URL patterns</ul> </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/7419/files#diff-992ec7c28d25fd54f6491d295389757705cd114bc869a35cba50d42e548cdc6e">+2/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>operation.go</strong><dd><code>Describe Operations keyed by operationID</code> </dd></summary> <hr> apidef/oas/operation.go - Document `Operations` map keyed by `operationID` </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/7419/files#diff-6d92d2d5b09a5fa7129609bb7cd0d383d015250ec07062b6a93a83257be51fb5">+1/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>root.go</strong><dd><code>Expand Internal field exposure semantics</code> </dd></summary> <hr> apidef/oas/root.go - Elaborate `State.Internal` behavior and references </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/7419/files#diff-9c56b2bdb992e0a7db76809d4c516e1cd61c9486c7f0437b344c0032476af80f">+1/-1</a> </td> </tr> <tr> <td> <details> <summary><strong>server.go</strong><dd><code>Fix ListenPath strip example URL</code> </dd></summary> <hr> apidef/oas/server.go - Fix base URL typo in strip example </details> </td> <td><a href="https://github.com/TykTechnologies/tyk/pull/7419/files#diff-21857c42e8659f7980014e277c3c758703f29e9e5c0c40553f2584cddb870808">+1/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> </details> ___
User description
Contributor checklist
New Contributors
master
PR Type
Documentation
Description
Clarify middleware configuration wording
Fix Traffic Transformation links and anchors
Remove outdated OSS qualifier for Operator
Minor formatting cleanup in config snippet
Diagram Walkthrough
File Walkthrough
gateway-config-tyk-classic.md
Clarify middleware options and fix references
tyk-docs/content/api-management/gateway-config-tyk-classic.md
tyk-gateway-features-include.md
Update Tyk Operator wording in features
tyk-docs/content/shared/tyk-gateway-features-include.md
logs-metrics.md
Minor formatting cleanup in example
tyk-docs/content/api-management/logs-metrics.md