-
Notifications
You must be signed in to change notification settings - Fork 167
Configure Custom Rate Limiting using Custom Plugins #6950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Code Review: PR #6950 - Update rate-limit.mdOverviewThis PR adds a new "Custom Plugin Rate Limiter Example" section to the rate-limit.md documentation, demonstrating how to implement IP-based rate limiting using a custom Go plugin. Technical AssessmentThe code example provided is technically sound and follows Tyk's best practices:
Diagram AccuracyThe included mermaid diagram accurately represents the flow:
ConclusionThis PR provides valuable documentation that clearly demonstrates how to implement IP-based rate limiting using custom Go plugins. The code is technically accurate and follows best practices. I recommend approving this PR. Tip: Mention me again using |
✅ PS. Add to the end of url /docs/nightly
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: andyo-tyk <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the accuracy of some of my suggestions - in particular regarding multi-auth
Co-authored-by: andyo-tyk <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>
Co-authored-by: andyo-tyk <[email protected]>
/release to release-5.8 |
/release to release-5.9 |
Working on it! Note that it can take a few minutes. |
1 similar comment
Working on it! Note that it can take a few minutes. |
(cherry picked from commit 40ec72e)
@sharadregoti Created merge PRs |
(cherry picked from commit 40ec72e)
@sharadregoti Created merge PRs |
User description
Contributor checklist
New Contributors
master
PR Type
Documentation
Description
Add Go plugin rate limiter example
Demonstrate IP-based rate limit via metadata
Clarify usage with custom auth plugins
Reinforce session setup for rate limiting
Diagram Walkthrough
File Walkthrough
rate-limit.md
Add Go example for IP-based rate limiting
tyk-docs/content/api-management/rate-limit.md
rate_limit_pattern
).