You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor grammatical issues: use "A Session is set" or "The session is set" consistently, "middleware chain after the authentication middleware layer" could be simplified, and "returns an empty object" might be clearer as "returns an empty session".
{{< note warning >}}
**Note**
The Session is set during the (custom) Authentication layer - meaning it won't be set until the middleware chain after the authentication middleware layer. Trying to use `ctx.GetSession` in a custom auth plugin would always return an empty object.
{{< /note >}}
The invocation of `ctx.GetSession(r)` returns an SessionState object.
Use consistent casing for "Session/session" and "Authentication/auth" throughout the note to match house style; also consider "ctx.GetSession(r)" for consistency with the following paragraph.
{{< note warning >}}
**Note**
The Session is set during the (custom) Authentication layer - meaning it won't be set until the middleware chain after the authentication middleware layer. Trying to use `ctx.GetSession` in a custom auth plugin would always return an empty object.
{{< /note >}}
The invocation of `ctx.GetSession(r)` returns an SessionState object.
Clarify that ctx.GetSession(r) returns nil/no session rather than an "empty object" to avoid misleading Go developers. Also remove duplicate spaces and fix the article to "a SessionState object" for accuracy and readability.
{{< note warning >}}
-**Note** +Note:-The Session is set during the (custom) Authentication layer - meaning it won't be set until the middleware chain after the authentication middleware layer. Trying to use `ctx.GetSession` in a custom auth plugin would always return an empty object.+The session is set during the (custom) authentication layer—meaning it won't be available until the middleware chain after the authentication middleware layer. Trying to use `ctx.GetSession(r)` in a custom auth plugin will return no session (nil).
{{< /note >}}
Suggestion importance[1-10]: 6
__
Why: The clarification from “empty object” to “no session (nil)” improves technical accuracy for Go readers and cleans minor wording issues. It’s a helpful documentation fix with moderate impact and correctly targets the new hunk lines.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sharadregoti
changed the title
User description
Contributor checklist
New Contributors
masterPR Type
Documentation
Description
Add warning note about session timing
Clarify ctx.GetSession behavior in auth plugins
Diagram Walkthrough
File Walkthrough
golang.md
Add session timing warning for Go pluginstyk-docs/content/api-management/plugins/golang.md