Fix optional and undefined properties for custom types
#94
+119
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # CHANGELOG.md # packages/typir/src/kinds/custom/custom-type.ts
insafuhrmann
approved these changes
Sep 11, 2025
There was a problem hiding this comment.
Thanks for these fixes @JohannesMeierSE. I am going to approve but I'd like to understand the topic in my detail remark.
| ### Fixed bugs | ||
|
|
||
| - Initializing optional properties of custom types with `undefined` failed, as reported in [#77](https://github.com/TypeFox/typir/discussions/77#discussioncomment-14149139). | ||
| - When checking the equality of custom types, the values for the same property might have different TypeScript types, since optional propeties might be set to `undefined`. |
There was a problem hiding this comment.
Suggested change
| - When checking the equality of custom types, the values for the same property might have different TypeScript types, since optional propeties might be set to `undefined`. | |
| - When checking the equality of custom types, the values for the same property might have different TypeScript types, since optional properties might be set to `undefined`. |
insafuhrmann
approved these changes
Oct 28, 2025
| firstValue: typeof value1, | ||
| secondValue: typeof value2, | ||
| firstValue: `'${String(value1)}' has the TypeScript type ${typeof value1}`, | ||
| secondValue: `'${String(value2)}' has the TypeScript type ${typeof value2}`, |
There was a problem hiding this comment.
I like this addition. Thanks!
JohannesMeierSE
deleted the
jm/77-fix-custom-types-optional-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of optional properties for custom types:
undefinedin explicit way to optional properties.undefinedin explicit way.