-
Couldn't load subscription status.
- Fork 100
Create SPECT subsets from ProjData #1596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dbc8d56 to
86a5de0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 small changes required.
Also, how different is src/test/test_proj_data_info_subsets_spect.cxx from PET? I didn't check, but it's likely most of it is the same. Easy to avoid overlap? (could derive both from one class)
…le interfile, REMOVE deprecated code from SPECTUB_Tools
|
Hmm... this worked on my local machine - segfaults here. |
|
The Debug build has the following: https://github.com/UCL/STIR/actions/runs/18319764443/job/52169585055?pr=1596#step:12:231 |
remove duplicate comments introduced by accident.
7cd57d1 to
37d2193
Compare
I did check. There is some scope for reducing overlap, e.g. by putting the code that explicitly loops over viewgrams to check if they are the same in both PET and SPECT versions etc. However, this will have to remain for later. |
|
I've done some minor clean-up. If (when?) tests succeed, I'll squash-merge this. Let me know ASAP if you prefer a normal merge. |
Changes in this pull request
Add ability to create SPECT subsets with partitioner (as separate ProjData)
Testing performed
None, as yet. Tests require template data (I'll sort this soon)
Related issues
Fixes segfaults arising from using partitioner (SIRF-contribs) on SPECT ProjData
Checklist before requesting a review
documentation/release_XXX.mdhas been updated with any functionality change (if applicable)