-
Notifications
You must be signed in to change notification settings - Fork 15
Param Revamp - Other Adult Cancer #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Yes, I agree with this approach. I have raised an issue #1681 to flag this recurrent problem. Would be good to wait until resolution of this issue before merging this (and other param revamp) PRs.
If write-up doesn't explicitly state this was calibrated, policy for now is to assume it wasn't, and ask developers to review later.
I agree, different settings may have different guidelines with regards to age thresholds for care
I would have done the same. We can always ask developers to double check. |
|
@marghe-molaro added back comment of code and comment discrepancy |
| df.at[person_id, "oac_stage_at_which_treatment_given"] = df.at[person_id, "oac_status"] | ||
|
|
||
| # Schedule a post-treatment check for 12 months: | ||
| # (NOTE: discrepancy between comment and value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed -- so we should correct the comment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue is that we currently don't know if it should be 3 months (current parameter value) or 12 months (current code value). Plan was to leave comment as-is.
I have updated the comment to be the current parameter value, and I have added the original value from the comment in the (NOTE) section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to @andrew-phillips-1 the issue is in the code, not the comment (see discussion in Issue #1681)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, thanks for the clarification here @marghe-molaro
|
Thanks so much @mmsuarezcosta and @marghe-molaro for this. I've had a look at just this one and we're definitely on the right track. I've added a few comments already, but on the actual paramneters.csv I couldn't add line specific comments, so have done it here instead. In a couple of places, I would say the parameters could be 'universal' (rather than 'local') as indicated below. Let me know if you disagree. But this kind of pattern I would expect to be quite common across the modules, so I thought worth raising.
|
|
# Conflicts: # src/tlo/methods/other_adult_cancers.py
…nce updated in master
|
I would think it was hard to regard any of these as universal since this is a mixture of all other adults cancers ? |
That is a fair point. At the same time, the way we have defined 'universal' is that the variable should be agnostic of local differences. Thus, anything that has to with test sensitivity/ specificity, disease progression, or death rates are defined as 'universal'. I would argue to keep the values defined as universal above as-is. Would be good to also have @marghe-molaro input on this. |
|
Happy for you to stick with "universal" for the reasons you state. |
Updating other adult cancer cancer parameters (removing module hardcoding and adding labels)
To Note:
Discrepancies between comments and values (this is the original code before I removed the hard-coding. The parameter values are that which were previously hard-coded (I ignored the commetns):
Parameters to Review labeling:
Reference Notes:
NA