-
Notifications
You must be signed in to change notification settings - Fork 279
fix(ui5-tokenizer): scroll to end when adding tokens from suggestions #12242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could adjust the PR title and description, the scroll to end improvement is specifically for the case when the items are being currently selected from the open suggestion popover
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a visual issue where the tokenizer was not scrolling to show the end of long tokens when adding/removing items through suggestions. The solution introduces intelligent scrolling behavior that automatically scrolls to the end when no specific token is focused, while preserving focused token visibility.
- Introduces a focused token tracking system (
_focusedToken
) to manage scroll behavior - Adds automatic scroll-to-end functionality when tokenizer is expanded without a focused token
- Refactors token navigation and scroll logic for better user experience
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
packages/main/src/Tokenizer.ts | Implements the core scrolling fix with focused token tracking and intelligent scroll behavior |
packages/main/src/MultiInput.ts | Removes redundant scroll calls that are now handled by the tokenizer automatically |
packages/main/src/MultiComboBox.ts | Removes redundant scroll calls that are now handled by the tokenizer automatically |
packages/main/cypress/specs/Tokenizer.cy.tsx | Adds comprehensive test coverage for the new scrolling behaviors |
Fixes: #12104
Fix the visual issue when add/remove items through suggestions to tokenizer by scrolling tokenizer to the end.