chore(ui5-toolbar): toolbar item wrapper introduced #12243
Conversation
…nto poc-toolbar-item
| @@ -60,6 +74,17 @@ class ToolbarItem extends UI5Element { | |||
| @property({ type: Boolean }) | |||
| isOverflowed: boolean = false; | |||
|
|
|||
| /** | |||
packages/main/src/ToolbarItem.ts
Outdated
| @@ -16,13 +20,23 @@ type ToolbarItemEventDetail = { | |||
| bubbles: true, | |||
| }) | |||
|
|
|||
| @event("click", { | |||
There was a problem hiding this comment.
do we need this click event?
| @@ -107,10 +132,27 @@ class ToolbarItem extends UI5Element { | |||
| }, | |||
| }; | |||
| } | |||
|
|
|||
| constructor() { | |||
| super(); | |||
There was a problem hiding this comment.
since the constructor doesn't handle any arguments, this override can be omitted
packages/main/src/ToolbarItem.ts
Outdated
| * If `preventOverflowClosing` is false, it will fire a "close-overflow" event. | ||
| */ | ||
| onClick(e: Event): void { | ||
| e.stopImmediatePropagation(); |
There was a problem hiding this comment.
We stop the propagation here which may lead to apps not being able to handle the click event on a higher level container. If possible, let's try to avoid that.
|
|
||
| export default function ToolbarItemTemplate(this: ToolbarItem) { | ||
| return ( | ||
| <div onClick={this.onClick}> |
There was a problem hiding this comment.
Once we have a sample with different types of components we should test if this click only event handling is enough to manage the closing of the popover. If not we should extend it or think of another mehanism.
| @@ -0,0 +1,68 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Let's add other components : Title, Text, Input, CheckBox, ToggleButton, DIV
…nto poc-toolbar-item
No description provided.