Skip to content

fix(OpenUI5Support): override default [popover] styles #12301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(OpenUI5Support): override default [popover] styles #12301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8746522
fix(OpenUI5Support): override default [popover] styles
TeodorTaushanov Sep 11, 2025
c6d1b58
Merge remote-tracking branch 'origin/main' into patch_popup_styles
TeodorTaushanov Sep 12, 2025
4fb3545
chore: make selector more specific
TeodorTaushanov Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/base/src/css/OpenUI5PopupStyles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[data-sap-ui-popup][popover] {
border: none;
overflow: visible;
margin: 0;
}
10 changes: 10 additions & 0 deletions packages/base/src/features/insertOpenUI5PopupStyles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { hasStyle, createStyle } from "../ManagedStyles.js";
import openUI5PopupStyles from "../generated/css/OpenUI5PopupStyles.css.js";

const insertOpenUI5PopupStyles = () => {
if (!hasStyle("data-ui5-popup-styles")) {
createStyle(openUI5PopupStyles, "data-ui5-popup-styles");
}
};

export default insertOpenUI5PopupStyles;
2 changes: 2 additions & 0 deletions packages/base/src/features/patchPopup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// OpenUI5's Control.js subset
import getSharedResource from "../getSharedResource.js";
import insertOpenUI5PopupStyles from "./insertOpenUI5PopupStyles.js";

type Control = {
getDomRef: () => HTMLElement | null,
Expand Down Expand Up @@ -137,6 +138,7 @@ const createGlobalStyles = () => {
};

const patchPopup = (Popup: OpenUI5Popup) => {
insertOpenUI5PopupStyles();
patchOpen(Popup); // Popup.prototype.open
patchClosed(Popup); // Popup.prototype._closed
createGlobalStyles(); // Ensures correct popover positioning by OpenUI5 (otherwise 0,0 is the center of the screen)
Expand Down
Loading