[WIP] UMIP-179: Updates #602

pxrl · 2024-04-22T10:03:45Z

Truncate LP fee precision to 8 (tbd) decimals.
Remove deprecated legacy v3 events.
Add link to OZ audit reports.

- Specify proposer action on invalid FilledV3Relay repaymentChainId. - Clarify proposer action on un-executable RelayerRefundLeaf. - Add link to OZ audit for Across V3.

pxrl · 2024-04-22T10:15:57Z

UMIPs/umip-179.md

+If a validated `FilledV3Relay` event specifies an invalid `repaymentChainId`, the proposer shall issue repayment on the fill destination chain.
+Reasons for the `repaymentChainId` to be considered invalid are:
+- `repaymentChainId` is not supported by Across.
+- `inputToken` is not supported as a repayment token on `repaymentChainId`.


I think forcing repayment on the destination chain is the only safe approach here, since if the relayer fills via a contract on zkSync and the proposer proposes repayment on some other chain then the relayer will never receive their repayment.

Yeah, good point. I think that's right.

pxrl · 2024-04-22T10:29:29Z

UMIPs/umip-179.md

- The LP fee is typically referenced as a multiplier of the `V3FundsDeposited` `inputAmount`, named `realizedLpFeePct` elsewhere in this document.
+- The LP fee as a multiplier of `inputAmount` (typically named `realizedLpFeePct` elsewhere in this document) shall be:
+  - Promoted to 18 decimals, where 1e18 represents 100%, and
+  - Truncated (zeroed) between 0 and 1e10, providing 8 decimals of effective precision.


Would appreciate feedback on the wording here.

Do you think it's easier to understand if you show the math?

The LP fee is truncated via the following formula: output = input / 1e10 * 1e10

Maybe:

- Available precision to 8 decimals. Truncated via [output = input / 1e10 * 1e10]

Updated: 518c7ec

mrice32

Looks good! A few minor comments. Only issue I see is that one part is ambiguous.

mrice32 · 2024-05-06T13:38:54Z

UMIPs/umip-179.md

- The LP fee is typically referenced as a multiplier of the `V3FundsDeposited` `inputAmount`, named `realizedLpFeePct` elsewhere in this document.
+- The LP fee as a multiplier of `inputAmount` (typically named `realizedLpFeePct` elsewhere in this document) shall be:
+  - Promoted to 18 decimals, where 1e18 represents 100%, and
+  - Truncated (zeroed) between 0 and 1e10, providing 8 decimals of effective precision.


Do you think it's easier to understand if you show the math?

The LP fee is truncated via the following formula: output = input / 1e10 * 1e10

mrice32 · 2024-05-06T13:39:28Z

UMIPs/umip-179.md

 ### Computing Relayer Repayments
 For a validated `FilledV3Relay` event, the relayer repayment amount shall be computed as follows:
- `(inputAmount * (1 - realizedLpFeePct)) / 1e18`, where `realizedLpFeePct` is computed over the set of HubPool `l1Token`, `originChainId` and `repaymentChainId` at the HubPool block number corresponding to the relevant `V3FundsDeposited` `quoteTimestamp`.
+- `(inputAmount * (1e18 - realizedLpFeePct)) / 1e18`, where `realizedLpFeePct` is computed over the set of HubPool `l1Token`, `originChainId` and `repaymentChainId` at the HubPool block number corresponding to the relevant `V3FundsDeposited` `quoteTimestamp`.


mrice32 · 2024-05-06T13:50:25Z

UMIPs/umip-179.md

+If a validated `FilledV3Relay` event specifies an invalid `repaymentChainId`, the proposer shall issue repayment on the fill destination chain.
+Reasons for the `repaymentChainId` to be considered invalid are:
+- `repaymentChainId` is not supported by Across.
+- `inputToken` is not supported as a repayment token on `repaymentChainId`.


Yeah, good point. I think that's right.

UMIPs/umip-179.md

james-a-morris

two possible copy changes

james-a-morris · 2024-07-23T15:34:30Z

UMIPs/umip-179.md

- The LP fee is typically referenced as a multiplier of the `V3FundsDeposited` `inputAmount`, named `realizedLpFeePct` elsewhere in this document.
+- The LP fee as a multiplier of `inputAmount` (typically named `realizedLpFeePct` elsewhere in this document) shall be:
+  - Promoted to 18 decimals, where 1e18 represents 100%, and
+  - Truncated (zeroed) between 0 and 1e10, providing 8 decimals of effective precision.


Maybe:

- Available precision to 8 decimals. Truncated via [output = input / 1e10 * 1e10]

james-a-morris · 2024-07-23T15:37:12Z

UMIPs/umip-179.md

-
-Note:
- If a particular relayer refund is known to be unexecutable, it can be removed from the bundle by the proposer if a sufficient public justification is made before the proposal. This is intended to deal with unlikely situations, such as ag centralized token issuer blacklisting an address that is due a refund. If this leaf were to remain unaltered, this blacklisted address could block other addresses from recieving refunds.
+Across v3 has been [audited by OpenZeppelin](https://blog.openzeppelin.com/across-v3-incremental-audit).


Suggested change

Across v3 has been [audited by OpenZeppelin](https://blog.openzeppelin.com/across-v3-incremental-audit).

Across v3 has been audited by OpenZeppelin, shared [here](https://blog.openzeppelin.com/across-v3-incremental-audit) and [here](https://blog.openzeppelin.com/across-v3-and-oval-incremental-audit).

Good call. It looks like OZ haven't posted about their most recent audit yet. @mrice32 are we able to prompt on that?

…fication

UMIPs/umip-179.md

nicholaspai · 2025-03-06T16:29:00Z

UMIPs/umip-179.md

 - The LP fee is computed between the `originChainId` specified by the `Deposit` and `repaymentChainId` specified by the relayer, where the `relayExecutionInfo.FillType != SlowFill` and the Fill `destinationChainId` otherwise.
+- The LP fee as a multiplier of `inputAmount` (typically named `realizedLpFeePct` elsewhere in this document) shall be:
+  - Promoted to 18 decimals, where 1e18 represents 100%, and
+  - Truncated to 8 decimals of effective precision, as follows: lpFee = (inputAmount / 1e10) * 1e10


Why 8? why not 6? Just curious how you selected 8, as I imagine the fewest # of precision decimals we can use -- the better UX

nicholaspai · 2025-03-10T22:07:48Z

Note that we should not merge in this PR without including language about truncating the # of decimals of precision for netSendAmounts and runningBalances

[fix]: Address UMIP-179 feedback

867733d

- Specify proposer action on invalid FilledV3Relay repaymentChainId. - Clarify proposer action on un-executable RelayerRefundLeaf. - Add link to OZ audit for Across V3.

pxrl requested review from mrice32 and nicholaspai April 22, 2024 10:03

Fix repayment chain wording

a45310c

pxrl commented Apr 22, 2024

View reviewed changes

pxrl added 2 commits April 22, 2024 12:19

Fix 1 -> 1e18

d06ad9e

Clarify LP fee precision

4812cc3

pxrl commented Apr 22, 2024

View reviewed changes

pxrl requested review from bmzig and james-a-morris April 22, 2024 14:20

mrice32 reviewed May 6, 2024

View reviewed changes

james-a-morris reviewed Jul 23, 2024

View reviewed changes

pxrl requested review from Reinis-FRP and chrismaree October 8, 2024 14:34

pxrl mentioned this pull request Dec 19, 2024

improve(Dataworker): Remove 0-value refunds and 0-value empty-message slow fills across-protocol/relayer#1957

Merged

pxrl mentioned this pull request Jan 21, 2025

feat: Support pending SpokePool upgrades #611

Merged

Merge remote-tracking branch 'origin/master' into pxrl-umip-179-clari…

fda9840

…fication

pxrl commented Mar 6, 2025

View reviewed changes

UMIPs/umip-179.md Outdated Show resolved Hide resolved

pxrl added 5 commits March 6, 2025 11:58

Update UMIPs/umip-179.md

7d2dae0

update

bcc6ab9

Add audits

c33df0f

Tweak lp fee truncation

518c7ec

Drop legacy types

27a18ac

pxrl requested a review from grasphoper March 6, 2025 11:15

pxrl changed the title ~~[WIP] [fix]: Address UMIP-179 feedback~~ [WIP] UMIP-179: Updates Mar 6, 2025

nicholaspai reviewed Mar 6, 2025

View reviewed changes

	Across v3 has been [audited by OpenZeppelin](https://blog.openzeppelin.com/across-v3-incremental-audit).
	Across v3 has been audited by OpenZeppelin, shared [here](https://blog.openzeppelin.com/across-v3-incremental-audit) and [here](https://blog.openzeppelin.com/across-v3-and-oval-incremental-audit).

[WIP] UMIP-179: Updates #602

Are you sure you want to change the base?

[WIP] UMIP-179: Updates #602

Uh oh!

Conversation

pxrl commented Apr 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mrice32 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

james-a-morris left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicholaspai commented Mar 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pxrl commented Apr 22, 2024 •

edited

Loading

mrice32 left a comment •

edited

Loading