feat(v3-sdk): support for swaprouter02 without deadline #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue mention by issue #28 - it constructs the correct swapCallParameters based on the passed in swapRouterType, making deadline optional, This PR does not break the support for the original SwapRouter as well. With many apps depending on base swaps, and in base chain deployments, the swaprouter02 is the only contract that's supported, so this is high priority for some of us.
How Has This Been Tested?
Manually tested
Are there any breaking changes?
No breaking changes (only added new typescript files that doesn't effect any of the previous versions)
(Optional) Feedback Focus
(Optional) Follow Ups
Nothing of such