Proofread #11
Merged
Proofread #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scarere
commented
Sep 29, 2025
|
|
||
| ## Automatic Restarts | ||
|
|
||
| **NOTE:** There is currently no premption on the Killarney cluster |
There was a problem hiding this comment.
Maybe also worth noting somewhere in this documentation the nuance with all code having to reside in the scratch space. This leads to some weirdness with the uv cache, etc. It almost might be better to use scratch as a home directory and use home directory as a backup for files.
|
I've tested the mlp example. Haven't tested the other templates but the changes I made should be trivial. Going to merge now without review or further testing since this is needed for the workshop tomorrow, but will have time to test for issues in the morning before the advanced workshop takes place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested out some of the basic examples and read through documentation. Overall really great and clear. Just had a few minor clarifications that I added in. Additionally ran into a few issues when testing the mlp template and had a few questions that might be worth answering in the documentation.
I added comments to the markdown as I was going but used
[//]: <> ()syntax so that they wouldn't actually render. I recommend you guys make some commits ontop of this PR to address some of the things I wasn't sure about and then we can merge it in.