-
Notifications
You must be signed in to change notification settings - Fork 85
feat: add account historical transactions #4745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0cc23ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
daf9971
to
c8b5be8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the designs, the second select is meant to enable filtering by token, not by specific market. I looked for conversations you might have had with Pavel about this but couldn't find anything.
Designs:
PR:
Also, in this PR we show the vToken name instead of the transaction value in dollars of each item transaction:
Designs:
PR:
apps/evm/src/pages/Account/NewPage/Transactions/TransactionsList/index.tsx
Outdated
Show resolved
Hide resolved
apps/evm/src/pages/Account/NewPage/Transactions/TransactionsList/index.tsx
Outdated
Show resolved
Hide resolved
apps/evm/src/pages/Account/NewPage/Transactions/TransactionRow/index.tsx
Outdated
Show resolved
Hide resolved
apps/evm/src/pages/Account/NewPage/Transactions/TransactionRow/index.tsx
Show resolved
Hide resolved
apps/evm/src/pages/Account/NewPage/Transactions/TransactionRow/index.tsx
Outdated
Show resolved
Hide resolved
apps/evm/src/clients/api/queries/getAccountHistoricalTransactions/types.ts
Outdated
Show resolved
Hide resolved
apps/evm/src/clients/api/queries/getAccountHistoricalTransactions/index.ts
Outdated
Show resolved
Hide resolved
apps/evm/src/clients/api/queries/getAccountHistoricalTransactions/index.ts
Outdated
Show resolved
Hide resolved
I think filtering down by market (or by single origin contract let's say) makes much more sense, because underlying tokens are shared in multiple markets. If one selects USDT, then there's a situation where it returns all USDT markets TXs and no way to filter to a single one. Same when other events get added, if XVS is selected then it is the XVS market along with vault stakes, votes, etc. |
Is it not the purpose of this feature? I can imagine a user who holds USDT in their wallet and supplied some to multiple pools would want to see their history for this token specifically, across all pools/vaults. |
In my opinion that would be very annoying if you wanted to check, let's say, the last time you supplied to a market but you had to go through more recent txs from other sources that share the same underlying token until you find the one you were looking for, instead of just filtering the exact market (or vault, if we consider XVS as another example of this case). |
I get your point. If Pavel is ok with this UX then that works for me 👍 |
c8b5be8
to
9c52206
Compare
9c52206
to
3f29977
Compare
3c1843c
to
1b8a4e2
Compare
apps/evm/src/pages/Account/NewPage/Transactions/TransactionRow/index.tsx
Outdated
Show resolved
Hide resolved
apps/evm/src/pages/Account/NewPage/Transactions/TransactionRow/index.tsx
Outdated
Show resolved
Hide resolved
apps/evm/src/clients/api/queries/getAccountTransactionHistory/formatApiTransaction.ts
Outdated
Show resolved
Hide resolved
1b8a4e2
to
1acf07e
Compare
PR looks good, but I approved right before finding a bug with the filtering system. On an account with several supply transactions, if I filter by "Supplies" transactions I see none of them. I'm seeing a similar behavior with other transaction types, where some or all transactions of that type are being filtered out. |
0ca5e8e
to
0cc23ef
Compare
Jira ticket(s)
VPD-58
Changes
evm app