Skip to content

Conversation

gleiser-oliveira
Copy link
Contributor

Jira ticket(s)

VPD-58

Changes

evm app

  • Added tab, components and logic to fetch and display the account's historical transactions

Copy link

changeset-bot bot commented Sep 8, 2025

🦋 Changeset detected

Latest commit: 0cc23ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
app.venus.io Error Error Sep 12, 2025 4:21pm
dapp-preview Ready Ready Preview Sep 12, 2025 4:21pm
dapp-testnet Ready Ready Preview Sep 12, 2025 4:21pm
1 Skipped Deployment
Project Deployment Preview Updated (UTC)
venus.io Skipped Skipped Sep 12, 2025 4:21pm

Copy link
Contributor

github-actions bot commented Sep 8, 2025

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 80.17% 34975 / 43621
🔵 Statements 80.17% 34975 / 43621
🔵 Functions 61.75% 536 / 868
🔵 Branches 71.88% 3864 / 5375
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/clients/api/index.ts 0% 0% 0% 0% 1-236
apps/evm/src/clients/api/queries/getAccountTransactionHistory/formatApiTransaction.ts 93.33% 0% 100% 93.33% 1, 44-45, 69
apps/evm/src/clients/api/queries/getAccountTransactionHistory/index.ts 96.77% 72.72% 100% 96.77% 1, 29
apps/evm/src/clients/api/queries/getAccountTransactionHistory/useGetAccountTransactionHistory.ts 0% 0% 0% 0% 1-42
apps/evm/src/components/Icon/icons/index.ts 98.63% 0% 100% 98.63% 1
apps/evm/src/components/Icon/icons/transactionCollateral.tsx 100% 50% 100% 100%
apps/evm/src/components/Icon/icons/transactionFile.tsx 100% 50% 100% 100%
apps/evm/src/components/Icon/icons/transactionIn.tsx 100% 50% 100% 100%
apps/evm/src/components/Icon/icons/transactionLink.tsx 100% 50% 100% 100%
apps/evm/src/components/Icon/icons/transactionOut.tsx 100% 50% 100% 100%
apps/evm/src/components/Pagination/index.tsx 92.64% 80% 20% 92.64% 52-53, 80-83
apps/evm/src/components/Select/index.tsx 93.52% 75% 50% 93.52% 59, 64, 69, 75-76, 83-85, 91
apps/evm/src/constants/functionKey.ts 100% 50% 100% 100%
apps/evm/src/hooks/useIsFeatureEnabled/index.tsx 99.38% 0% 100% 99.38% 1
apps/evm/src/pages/Account/NewPage/index.tsx 97.43% 73.91% 100% 97.43% 131-134
apps/evm/src/pages/Account/NewPage/Transactions/index.tsx 93.12% 76.92% 16.66% 93.12% 52-54, 58-62, 64-66, 80
apps/evm/src/pages/Account/NewPage/Transactions/TransactionDetails/index.tsx 100% 92.3% 100% 100%
apps/evm/src/pages/Account/NewPage/Transactions/TransactionRow/index.tsx 100% 93.33% 100% 100%
apps/evm/src/pages/Account/NewPage/Transactions/TransactionsList/index.tsx 97.29% 75% 100% 97.29% 40, 44
apps/evm/src/types/index.ts 97.36% 83.33% 100% 97.36% 7
Generated in workflow #11414 for commit 0cc23ef by the Vitest Coverage Report Action

Copy link
Member

@therealemjy therealemjy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the designs, the second select is meant to enable filtering by token, not by specific market. I looked for conversations you might have had with Pavel about this but couldn't find anything.
Designs:
Image
PR:
Screenshot 2025-09-08 at 08 22 40

Also, in this PR we show the vToken name instead of the transaction value in dollars of each item transaction:
Designs:
Screenshot 2025-09-08 at 08 48 51
PR:
Screenshot 2025-09-08 at 08 50 05

@gleiser-oliveira
Copy link
Contributor Author

According to the designs, the second select is meant to enable filtering by token, not by specific market. I looked for conversations you might have had with Pavel about this but couldn't find anything. Designs: Image PR: Screenshot 2025-09-08 at 08 22 40

Also, in this PR we show the vToken name instead of the transaction value in dollars of each item transaction: Designs: Screenshot 2025-09-08 at 08 48 51 PR: Screenshot 2025-09-08 at 08 50 05

I think filtering down by market (or by single origin contract let's say) makes much more sense, because underlying tokens are shared in multiple markets. If one selects USDT, then there's a situation where it returns all USDT markets TXs and no way to filter to a single one. Same when other events get added, if XVS is selected then it is the XVS market along with vault stakes, votes, etc.

@therealemjy
Copy link
Member

Is it not the purpose of this feature? I can imagine a user who holds USDT in their wallet and supplied some to multiple pools would want to see their history for this token specifically, across all pools/vaults.

@gleiser-oliveira
Copy link
Contributor Author

Is it not the purpose of this feature? I can imagine a user who holds USDT in their wallet and supplied some to multiple pools would want to see their history for this token specifically, across all pools/vaults.

In my opinion that would be very annoying if you wanted to check, let's say, the last time you supplied to a market but you had to go through more recent txs from other sources that share the same underlying token until you find the one you were looking for, instead of just filtering the exact market (or vault, if we consider XVS as another example of this case).

@therealemjy
Copy link
Member

I get your point. If Pavel is ok with this UX then that works for me 👍

@therealemjy
Copy link
Member

therealemjy commented Sep 12, 2025

PR looks good, but I approved right before finding a bug with the filtering system.

On an account with several supply transactions, if I filter by "Supplies" transactions I see none of them.

Without filtering:
Screenshot 2025-09-12 at 08 30 01

With filtering:
Screenshot 2025-09-12 at 08 30 05

I'm seeing a similar behavior with other transaction types, where some or all transactions of that type are being filtered out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants