Skip to content

[VEN-3000] Risk steward vips #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Sep 16, 2025
Merged

[VEN-3000] Risk steward vips #520

merged 32 commits into from
Sep 16, 2025

Conversation

coreyar
Copy link
Contributor

@coreyar coreyar commented Mar 7, 2025

Description

Resolves VEN

@coreyar coreyar requested a review from chechu March 7, 2025 18:54
@coreyar coreyar force-pushed the risk-steward-vips branch from 9730610 to 3ffa04f Compare March 10, 2025 13:12
@chechu chechu changed the title Risk steward vips [VEN-3000]: Risk steward vips Apr 7, 2025
@chechu chechu changed the title [VEN-3000]: Risk steward vips [VEN-3000] Risk steward vips Apr 7, 2025
chechu
chechu reviewed Apr 7, 2025
View reviewed changes
@Debugger022 Debugger022 self-requested a review July 3, 2025 13:58
Debugger022
Debugger022 reviewed Jul 3, 2025
View reviewed changes
Debugger022
Debugger022 reviewed Jul 3, 2025
View reviewed changes
@chechu chechu mentioned this pull request Jul 4, 2025
Closed
Debugger022
Debugger022 reviewed Jul 7, 2025
View reviewed changes
Debugger022
Debugger022 reviewed Jul 7, 2025
View reviewed changes
@Exef Exef requested a review from Debugger022 July 8, 2025 09:18
Debugger022
Debugger022 reviewed Jul 8, 2025
View reviewed changes
Debugger022
Debugger022 previously approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@Debugger022 Debugger022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Exef Exef requested a review from chechu July 10, 2025 09:12
@Exef Exef self-assigned this Jul 11, 2025
chechu
chechu reviewed Jul 11, 2025
View reviewed changes
chechu
chechu reviewed Jul 11, 2025
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simulations/vip-xxx/bsctestnet-addendum.ts LGTM

Diamond cut params (bsctestnet and bscmainnet) LGTM

chechu
chechu reviewed Jul 11, 2025
View reviewed changes
Copy link
Member

@chechu chechu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On testnet, we should initiate the transfer of the ownerships on the Receiver and Risk Steward contracts, and add a new addendum VIP to accept the ownership of these contracts on each network. The owner of every contract should be Normal Timelock

@Exef Exef requested review from chechu, Exef and Debugger022 July 16, 2025 08:58
GitGuru7
GitGuru7 reviewed Jul 22, 2025
View reviewed changes
@chechu
Copy link
Member

chechu commented Sep 16, 2025

https://app.venus.io/#/governance/proposal/544?chainId=56

@Exef Exef merged commit adf526f into main Sep 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGuru7 GitGuru7 GitGuru7 left review comments

@chechu chechu chechu approved these changes

@Exef Exef Awaiting requested review from Exef

@Debugger022 Debugger022 Awaiting requested review from Debugger022

Assignees

@Exef Exef

@web3rover web3rover

@coreyar coreyar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@coreyar @chechu @Exef @Debugger022 @GitGuru7 @web3rover