[VEN-3360][VEN-3361]: VIP to configure Emode in the BNB core pool #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitGuru7
changed the title
chechu
reviewed
Sep 11, 2025
kkirka
reviewed
Sep 12, 2025
| collateralFactor: 750000000000000000n, | ||
| }, | ||
| { | ||
| // Binance |
There was a problem hiding this comment.
What does "Binance" comment mean here?
|
Bsctestnet VIP LGTM |
chechu
reviewed
Sep 13, 2025
chechu
reviewed
Sep 13, 2025
| market.collateralFactor, | ||
| ]); | ||
| export const MARKETS_LI = CORE_MARKETS.map(market => [market.address, CURRENT_LIQUIDATION_INCENTIVE]); | ||
| export const MARKETS_BA = CORE_MARKETS.map(market => [0, market.address, true]); |
There was a problem hiding this comment.
I think isBorrowAllowed should be set to false in the following markets: asBNB, sUSDe, xSolvBTC and PT-sUSDE-JUN2025, because these markets are not borrowable in the Core pool, from business/risk point of view
chechu
reviewed
Sep 13, 2025
| expect(await unitroller.facetFunctionSelectors(OLD_SETTER_FACET)).to.deep.equal([]); | ||
| }); | ||
|
|
||
| it("unitroller should contain the new facet addresses", async () => { |
There was a problem hiding this comment.
Also for the reward and the policy facets?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description