[VEN-3342]: migrate markets and Comptroller to Solidity 0.8.25 #610
Conversation
|
Please verify the newly deployed contracts and add simulations to confirm the diamond cut updates for both facet addresses and their selectors. The command and facet selectors look good to me. Just to confirm—we’re intentionally updating the target of venusInitialIndex() from MarketFacet to RewardFacet, right? |
simulations/vip-541/bsctestnet.ts
Outdated
| await expectEvents(txResponse, [DIAMOND_ABI], ["DiamondCut"], [1]); | ||
| await expectEvents(txResponse, [UNITROLLER_ABI], ["NewImplementation"], [36]); |
There was a problem hiding this comment.
I would also check for the NewPendingImplementation event.
vips/vip-541/bsctestnet.ts
Outdated
| export const DIAMOND = "0x649616739bab52E2A98BC74d93c896Ca45944359"; | ||
| export const COMPTROLLER_LENS = "0x3ec96D6a9a14ee57aB83F81BB7386EBE515936D1"; | ||
| export const LIQUIDATOR = "0x55AEABa76ecf144031Ef64E222166eb28Cb4865F"; | ||
| export const LIQUIDATOR_IMPL = "0xe442A62E3B1956EC5B42e06aA0E293A0cB300406"; |
There was a problem hiding this comment.
We should set the treasuryPercent for the new liquidator in the VIP command.
There was a problem hiding this comment.
The liquidation process doesn't change in the updated contracts. I don't see why we should set the treasury percentage in the VIP. The current value should be valid, right?
UST and LUNA were delisted venusInitialIndex is set to the MarketFacet, not to the RewardFacet. It could be set to any facet, but let's keep it as it is
vips/vip-541/bscmainnet.ts
Outdated
| vWBETH: "0x6CFdEc747f37DAf3b87a35a1D9c8AD3063A1A8A0", | ||
| vXRP: "0xB248a295732e0225acd3337607cc01068e3b9c10", | ||
| vxSolvBTC: "0xd804dE60aFD05EE6B89aab5D152258fD461B07D5", | ||
| vXVS: "0x151B1e2635A717bcDc836ECd6FbB62B674FE3E1D", |
There was a problem hiding this comment.
We'll have to add the new WBNB market, after enabling it
chechu
force-pushed
the
feat/solidity-0.8
branch
from
721ad68 to
e48ed73
Compare
Description
Resolves VEN