Skip to content

Conversation

@Vardane
Copy link
Contributor

@Vardane Vardane commented Jul 30, 2021

Q R
Type of contribution ? Fix + Improvement
Tickets (issues) concerned non applicable

What have you changed ?
  • Upgraded djmoney to current version
  • Added a search field to event model, in order to allow filtering in Angular Front End
  • Added read and object read permission for any user, so that non-authenticated users may view the details of an event
How did you change it ?
  • Edited requirements.txt
  • Edited event model
  • Edited event model permission in user test file
Is there a special consideration?

None
(FYI: current 1.1 version breaks and returns an error message
web_1 | File "/code/api_volontaria/apps/position/models.py", line 12, in
web_1 | from djmoney.models.fields import MoneyField
web_1 | File "/usr/local/lib/python3.8/site-packages/djmoney/models/fields.py", line 12, in
web_1 | from djmoney import forms
web_1 | File "/usr/local/lib/python3.8/site-packages/djmoney/forms/init.py", line 1, in
web_1 | from .fields import * # noqa
web_1 | File "/usr/local/lib/python3.8/site-packages/djmoney/forms/fields.py", line 4, in
web_1 | from djmoney.money import Money
web_1 | File "/usr/local/lib/python3.8/site-packages/djmoney/money.py", line 9, in
web_1 | from moneyed.localization import _FORMATTER, format_money
web_1 | ModuleNotFoundError: No module named 'moneyed.localization')

Upgrading to 2.0.1 fixes the error. Tests run with no error.

Verification :

  • [ x] My branch name respect the standard defined in CONTRIBUTING.md
  • [ x] All my commits respect the standard defined in CONTRIBUTING.md
  • [ x] This Pull-Request fully meets the requirements defined in the issue
  • I added or modified the attached tests
  • I added or modified the documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant