Skip to content

Conversation

chmerdon
Copy link
Member

@chmerdon chmerdon commented Jul 8, 2025

the documentation of ExtendableFEM does not build anymore, reason is FEType dependence of some interpolation functions that look at the wrong parameter of the FEVectorBlock since the introduction of the new TVector parameter in version 1.2

@chmerdon chmerdon requested a review from pjaap July 8, 2025 16:08
Copy link
Member

@pjaap pjaap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should geneally test the show/display stuff. I had some problems back then starting with pdelib. Inspecting stuff in the REPL caused some crashes.

Do you know a nice way to to this systematically?

@chmerdon
Copy link
Member Author

chmerdon commented Jul 9, 2025

You are right. I don't know how to do that systematically, unfortunately. Maybe we can just sprinkle some @shows or @infos into the existing tests?

@pjaap
Copy link
Member

pjaap commented Jul 9, 2025

Sounds like a good start. Let's do this in another PR.

@chmerdon
Copy link
Member Author

chmerdon commented Jul 9, 2025

I'll add this to #45

@chmerdon chmerdon merged commit e8a21f8 into master Jul 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants