Add GitHub actions for linting/building of registry #91
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | 9450da8 |
| - name: Install dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run lint-staged |
There was a problem hiding this comment.
Can we break each linting and formatting task into its own job? This will ensure they all run in parallel and each will throw their own errors which means if the linting and formatting is broken we will get two errors instead of only one of them running and throwing an error.
| run: npm ci | ||
|
|
||
| - name: Run lint-staged | ||
| run: npx lint-staged |
There was a problem hiding this comment.
This command should be broken into two different jobs npx eslint ., and npx prettier --check .. npx lint-staged only runs on staged files which there will be none in the CI environment.
| DEPLOY_PRIME_URL: https://localhost:4321 | ||
| URL: https://wds-shadcn-registry.netlify.app | ||
|
|
||
| - name: Build registry |
There was a problem hiding this comment.
This doesn't actually ensure the registry that is committed is the same as the one built by this command. We probably need to add a diff step to ensure the code in the registry folder doesn't change after running this since if it does change it means the registry is not being built before pushing.
2 participants
Runs lint-staged, astro check, and registry build with required env vars (DEPLOY_PRIME_URL set to localhost - unsure if this is the best approach, open to feedback).
An example of the actions running can be seen in: https://github.com/LucasJantschChitolina/wds-shadcn-registry/actions/runs/17194290235/job/48774101967
closes #65