Skip to content

move description setting to a dedicated function with nonce checks to handle reported security issues #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

move description setting to a dedicated function with nonce checks to handle reported security issues #1001

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion inc/post-types.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2138,7 +2138,7 @@ function cptui_update_post_type( $data = [] ) {
// We are handling this special because we can't accurately get to exclude the description index
// in the cptui_filtered_post_type_post_global() function. So we clean this up from the $_POST
// global afterwards here.
$description = wp_kses_post( stripslashes_deep( $_POST['cpt_custom_post_type']['description'] ) );
$description = cptui_get_saved_description();

$name = trim( $data['cpt_custom_post_type']['name'] );
$rest_base = trim( $data['cpt_custom_post_type']['rest_base'] );
Expand Down Expand Up @@ -2584,3 +2584,20 @@ function cptui_custom_enter_title_here( $text, $post ) {
return $cptui_obj['enter_title_here'];
}
add_filter( 'enter_title_here', 'cptui_custom_enter_title_here', 10, 2 );

/**
* Get saved description value with added nonce check for extra security.
*
* @since 1.18.1
* @return string
*/
function cptui_get_saved_description() {
if ( empty( $_POST['cpt_custom_post_type']['description'] ) ) {
return '';
}

if ( ! empty( $_POST['cptui_select_post_type_nonce_field'] ) ) {
check_admin_referer( 'cptui_select_post_type_nonce_action', 'cptui_select_post_type_nonce_field' );
}
return wp_kses_post( stripslashes_deep( $_POST['cpt_custom_post_type']['description'] ) );
}